Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: spdk: update to latest spdk-18.05 branch #27451

Conversation

Projects
None yet
4 participants
@badone
Copy link
Contributor

commented Apr 9, 2019

also bump dpdk to to spdk-18.05 branch. this should fix the build
failure on Fedora 28

Signed-off-by: Kefu Chai kchai@redhat.com
(cherry picked from commit 8098e54)

Conflicts:
src/spdk

This fixes a problem building mimic with gcc8.

rte_table_hash_cuckoo.c:139:16: error: cast between incompatible function types from ‘rte_table_hash_op_hash’ {aka ‘long unsigned int (*)(void *, void *, unsigned int,  long unsi
gned int)’} to ‘uint32_t (*)(const void *, uint32_t,  uint32_t)’ {aka ‘unsigned int (*)(const void *, unsigned int,  unsigned int)’} [-Werror=cast-function-type]
   .hash_func = (rte_hash_function)(p->f_hash),   
                ^  
cc1: all warnings being treated as errors
  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
spdk: update to latest spdk-18.05 branch
also bump dpdk to to spdk-18.05 branch. this should fix the build
failure on Fedora 28

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 8098e54)

Conflicts:
	src/spdk

@badone badone added this to the mimic milestone Apr 9, 2019

@badone badone requested a review from tchaikov Apr 22, 2019

@tchaikov tchaikov removed the needs-review label Apr 23, 2019

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

jenkins re-test this please

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

oops - retriggering the Jenkins test was not needed here, sorry!

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

[ 74%] Linking CXX executable ../../../bin/unittest_memstore_clone
/usr/bin/ld: ../../../../src/spdk/build/lib/libspdk_util.a(uuid.o): undefined reference to symbol 'uuid_unparse_lower@@UUID_1.0'
/usr/lib/gcc/x86_64-linux-gnu/7/../../../x86_64-linux-gnu/libuuid.so: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
src/test/objectstore/CMakeFiles/unittest_memstore_clone.dir/build.make:147: recipe for target 'bin/unittest_memstore_clone' failed
make[3]: *** [bin/unittest_memstore_clone] Error 1
CMakeFiles/Makefile2:17850: recipe for target 'src/test/objectstore/CMakeFiles/unittest_memstore_clone.dir/all' failed
@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

jenkins test docs

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

jenkins test make check

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

@badone @tchaikov Does not build. Link error as shown above. Can you take a look?

@badone

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

oops - retriggering the Jenkins test was not needed here, sorry!

@smithfarm I thought this built the first time around, is that your recollection (not disputing it is not building now, just trying to get the facts straight)?

@badone

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2019

Early analysis indicates this is a problem with the location of '-luuid' in the linker command line. Looking into this further.

@badone

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2019

'-luuid' is in the same position on the command line for both centos and xenial, but in xenial the linking fails because '../../src/spdk/build/lib/libspdk_util.a' ends up after '-luuid' whereas centos (or its compiler) doesn't mind. Looks like we need to backport at least c2026b7 @tchaikov mind having a quick check to see if we need anything else?

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

@smithfarm I thought this built the first time around, is that your recollection (not disputing it is not building now, just trying to get the facts straight)?

So, I was going through all mimic PRs that had failing "make check" and triggering re-run of the tests. I got to this PR and did not immediately notice that the "X" in the Jenkins box was referring to "Unmodified Submodules" and retriggered tests. Then I thought to myself: "were there two Xs or just one?" It seemed to me that there was just one X, which would mean that "make check" passed the first time around. But I'm not sure :-(

@badone

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2019

@smithfarm Thanks Nathan, I'm now convinced it builds fine on CentOS but fails on Xenial so your description is what I believe to be the case as well. My testing so far shows c2026b7 should resolve the issue so I'll backport that in my morning.

@tchaikov

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

@badone i'd just leave the check to linker =) i agree that we can just cherry-pick the change and retry.

cmake: update BuildSPDK for spdk-18.05
in spdk v18.05, libuuid is linked by libspdk_util.a, in which,
it is used by lib/util/uuid.c. and libspdk_vol.a uses the wrapper
function exposed by libspdk_util.a, so update the CMakefile script to
reflect the change.

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit c2026b7)
@yuriw

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

@badone this passed tests, pls merge at will

@badone badone merged commit c1d909d into ceph:mimic May 2, 2019

3 of 4 checks passed

Unmodified Submodules Approval needed: modified submodules found
Details
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
make check make check succeeded
Details

@badone badone deleted the badone:wip-mimic-spdk-rte_table_hash_cuckoo_create-build-error branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.