Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: os/bluestore: call fault_range properly prior to looking for blob to … #27570

Merged
merged 1 commit into from May 1, 2019

Conversation

Projects
None yet
4 participants
@ifed01
Copy link
Contributor

commented Apr 12, 2019

os/bluestore: call fault_range properly prior to looking for blob to …
…reuse

Fixes: https://tracker.ceph.com/issues/21312

Signed-off-by: Igor Fedotov <ifedotov@suse.com>
(cherry picked from commit e0a395e)

@ifed01 ifed01 added this to the mimic milestone Apr 12, 2019

@ifed01 ifed01 requested a review from liewegas Apr 12, 2019

@xiexingguo

This comment has been minimized.

Copy link
Member

commented Apr 13, 2019

retest this please

@xiexingguo

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

@ifed01

[       OK ] TestAllocatorLevel01.test_l2_contiguous_alignment (1 ms)
[ RUN      ] TestAllocatorLevel01.test_4G_alloc_bug
Init L2 cont aligned
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/objectstore/fastbmap_allocator_test.cc:863: Failure
      Expected: a4.size()
      Which is: 0
To be equal to: 1u
      Which is: 1
[  FAILED  ] TestAllocatorLevel01.test_4G_alloc_bug (0 ms)
[ RUN      ] TestAllocatorLevel01.test_4G_alloc_bug2
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/objectstore/fastbmap_allocator_test.cc:881: Failure
      Expected: a4.size()
      Which is: 0
To be equal to: 1u
      Which is: 1
[  FAILED  ] TestAllocatorLevel01.test_4G_alloc_bug2 (0 ms)
[ RUN      ] TestAllocatorLevel01.test_4G_alloc_bug3
Init L2 cont aligned
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/objectstore/fastbmap_allocator_test.cc:921: Failure
      Expected: a4.size()
      Which is: 0
To be equal to: 2u
      Which is: 2
[  FAILED  ] TestAllocatorLevel01.test_4G_alloc_bug3 (0 ms)
[----------] 8 tests from TestAllocatorLevel01 (6794 ms total)

[----------] Global test environment tear-down
[==========] 8 tests from 1 test case ran. (6794 ms total)
[  PASSED  ] 5 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] TestAllocatorLevel01.test_4G_alloc_bug
[  FAILED  ] TestAllocatorLevel01.test_4G_alloc_bug2
[  FAILED  ] TestAllocatorLevel01.test_4G_alloc_bug3

 3 FAILED TESTS
@ifed01

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

@xiexingguo - thanks for pointing out. But these failures seem to be unrelated as they're present in mimic HEAD too. Investigating...

@xiexingguo

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

But these failures seem to be unrelated as they're present in mimic HEAD too. Investigating...

I understand. I thought it might be related to the recently backported fast bitmap allocator. Hence ping you:-)

@ifed01

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

@xiexingguo - allocator test failures have been fixed in #27606

@ifed01 ifed01 added the needs-qa label Apr 17, 2019

@ifed01

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

jenkins retest this please

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

@yuriw yuriw merged commit 4eac53d into ceph:mimic May 1, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@ifed01 ifed01 deleted the ifed01:wip-ifed-fix-21312-mimic branch May 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.