Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: osd: process_copy_chunk remove obc ref before pg unlock #27587

Merged
merged 1 commit into from May 1, 2019

Conversation

Projects
None yet
6 participants
@pdvian
Copy link

commented Apr 15, 2019

Zengran Zhang Prashant D
osd: process_copy_chunk remove obc ref before pg unlock
drop the obc ref when pg locked is more safer, if not, on_change
may failed to clear it, and on_flushed may find leak.

Fixes: http://tracker.ceph.com/issues/38842

Signed-off-by: Kefu Chai kchai@redhat.com
Signed-off-by: Zengran Zhang <zhangzengran@sangfor.com.cn>
(cherry picked from commit 7087439)

@tchaikov tchaikov added this to the mimic milestone Apr 15, 2019

@tchaikov

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

[  FAILED  ] 3 tests, listed below:
[  FAILED  ] TestAllocatorLevel01.test_4G_alloc_bug
[  FAILED  ] TestAllocatorLevel01.test_4G_alloc_bug2
[  FAILED  ] TestAllocatorLevel01.test_4G_alloc_bug3
...
The following tests FAILED:
	129 - unittest_fastbmap_allocator (Failed)

retest this please.

@tchaikov

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

retest this please.

@batrick batrick added the core label Apr 15, 2019

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

@tchaikov Same failures on re-run:

[  FAILED  ] TestAllocatorLevel01.test_4G_alloc_bug
[  FAILED  ] TestAllocatorLevel01.test_4G_alloc_bug2
[  FAILED  ] TestAllocatorLevel01.test_4G_alloc_bug3

 3 FAILED TESTS

@smithfarm smithfarm requested a review from tchaikov Apr 16, 2019

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

Ah, same failures are seen in another mimic backport PR: #27588

Looks like a regression in mimic.

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

jenkins re-test this please

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

@jdurgin

jdurgin approved these changes May 1, 2019

@yuriw yuriw merged commit 9294f7f into ceph:mimic May 1, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.