monitoring: Prometheus default alerts #27596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-philipp
changed the title
jan--f
force-pushed
the
prometheus-default-alerts
branch
2 times, most recently
from
8a06ee8
to
f73fb02
Compare
Signed-off-by: Jan Fajerski <jfajerski@suse.com>
jan--f
force-pushed
the
prometheus-default-alerts
branch
from
f73fb02
to
83014a3
Compare
b-ranto
reviewed
Apr 18, 2019
jan--f
force-pushed
the
prometheus-default-alerts
branch
from
83014a3
to
ac38067
Compare
b-ranto
reviewed
Apr 18, 2019
jan--f
force-pushed
the
prometheus-default-alerts
branch
from
ac38067
to
5982b5f
Compare
votdev
requested changes
Apr 23, 2019
jan--f
force-pushed
the
prometheus-default-alerts
branch
from
5982b5f
to
28383c1
Compare
votdev
approved these changes
Apr 23, 2019
votdev
requested changes
Apr 23, 2019
jan--f
force-pushed
the
prometheus-default-alerts
branch
from
28383c1
to
c0ac3dd
Compare
|
@votdev I assumed you wanted full stops after all description texts, not just the 5 instances you pointed out? |
Full stops are ok, too. I only wanted to see all descriptions ending the same way. |
votdev
approved these changes
Apr 23, 2019
LenzGr
reviewed
Apr 23, 2019
LenzGr
reviewed
Apr 23, 2019
LenzGr
reviewed
Apr 23, 2019
LenzGr
reviewed
Apr 23, 2019
LenzGr
reviewed
Apr 23, 2019
LenzGr
reviewed
Apr 23, 2019
LenzGr
reviewed
Apr 23, 2019
LenzGr
reviewed
Apr 23, 2019
LenzGr
reviewed
Apr 23, 2019
LenzGr
reviewed
Apr 23, 2019
LenzGr
approved these changes
Apr 23, 2019
jan--f
force-pushed
the
prometheus-default-alerts
branch
from
c0ac3dd
to
bc9a40d
Compare
|
As for packaging: I'm not sure it makes sense to add this to ceph.spec.in as a sub-package. Prometheus deployments are quite flexible, maybe it makes sense to leave this for downstream packagers? |
Agreed - let's tackle this separately. |
|
@b-ranto - OK to be merged from your POV? |
b-ranto
reviewed
Apr 25, 2019
Alerts are from https://github.com/SUSE/DeepSea/blob/SES5/srv/salt/ceph/monitoring/prometheus/files/ses_default_alerts.yml but updated for the mgr module and node_exporter >= 0.15. Signed-off-by: Jan Fajerski <jfajerski@suse.com>
jan--f
force-pushed
the
prometheus-default-alerts
branch
from
bc9a40d
to
c0e58bd
Compare
b-ranto
approved these changes
Apr 29, 2019
|
Jenkins test dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: http://tracker.ceph.com/issues/24977