Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: mgr: enable inter-module calls #27638

Merged
merged 1 commit into from May 3, 2019

Conversation

Projects
None yet
5 participants
@tchaikov
Copy link
Contributor

commented Apr 17, 2019

@tchaikov tchaikov added this to the mimic milestone Apr 17, 2019

@tchaikov tchaikov requested review from tserong and sebastian-philipp Apr 17, 2019

@tchaikov tchaikov force-pushed the tchaikov:mimic-39132 branch from 681ff6d to 4a63213 Apr 17, 2019

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

@tchaikov The line Fixes: https://tracker.ceph.com/issues/39132 is not present in the original commit message. When cherry-picking, to avoid polluting the git history we try to avoid changing the text above the line (cherry picked from commit ...). (Or rather, to avoid confusion since this text is expected to be a verbatim quote from the git history.)

So this added "Fixes" line, if it's deemed necessary, could be placed under that line, instead of above?

@sebastian-philipp

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

were there any noteworthy fixes to the remote() call after the initial implementation form John?

mgr: enable inter-module calls
This is being done by passing native CPython objects
back and forth.  It's safe because sub-interpreters in CPython
share memory allocation infrastructure and share the GIL.

With a view to PEP554, we limit inter-interpreter calls
to pickleable objects, so that this may be implemented
using byte-arrays in future.

This infrastructure should enable:
 - the dashboard to display the status of other modules, for
   example the set of progress indicators from `progress`
 - dashboard and restful to share an underlying long running
   job mechanism.

Signed-off-by: John Spray <john.spray@redhat.com>
(cherry picked from commit f02316a)

@tchaikov tchaikov force-pushed the tchaikov:mimic-39132 branch from 4a63213 to b4e2983 Apr 17, 2019

@tchaikov

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

@smithfarm i removed the "Fixes" line.

@sebastian-philipp thanks for the reminder. i checked. none.

@tchaikov

This comment has been minimized.

Copy link
Contributor Author

commented Apr 21, 2019

retest this please.

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

@yuriw yuriw merged commit 74ba552 into ceph:mimic May 3, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@neha-ojha

This comment has been minimized.

Copy link
Member

commented May 3, 2019

Though the original failure was not seen, I think we need a follow up fix for

2019-05-02T22:25:20.281 INFO:tasks.ceph.mgr.y.smithi174.stderr:2019-05-02 22:25:20.275 7fede3c3b700 -1 no module 'crash'
2019-05-02T22:25:20.282 INFO:teuthology.orchestra.run.smithi167.stderr:2019-05-02 22:25:20.277 7ff1697fa700  1 -- 172.21.15.167:0/2079532987 <== mgr.5933 172.21.15.174:6800/13624 1 ==== command_reply(tid 0: -22 Traceback (most recent call last):
2019-05-02T22:25:20.282 INFO:teuthology.orchestra.run.smithi167.stderr:  File "/usr/lib/ceph/mgr/telemetry/module.py", line 328, in handle_command
2019-05-02T22:25:20.282 INFO:teuthology.orchestra.run.smithi167.stderr:    self.self_test()
2019-05-02T22:25:20.282 INFO:teuthology.orchestra.run.smithi167.stderr:  File "/usr/lib/ceph/mgr/telemetry/module.py", line 384, in self_test
2019-05-02T22:25:20.282 INFO:teuthology.orchestra.run.smithi167.stderr:    self.compile_report()
2019-05-02T22:25:20.283 INFO:teuthology.orchestra.run.smithi167.stderr:  File "/usr/lib/ceph/mgr/telemetry/module.py", line 291, in compile_report
2019-05-02T22:25:20.283 INFO:teuthology.orchestra.run.smithi167.stderr:    report['crashes'] = self.gather_crashinfo()
2019-05-02T22:25:20.283 INFO:teuthology.orchestra.run.smithi167.stderr:  File "/usr/lib/ceph/mgr/telemetry/module.py", line 214, in gather_crashinfo
2019-05-02T22:25:20.283 INFO:teuthology.orchestra.run.smithi167.stderr:    errno, crashids, err = self.remote('crash', 'do_ls', '', '')
2019-05-02T22:25:20.283 INFO:teuthology.orchestra.run.smithi167.stderr:  File "/usr/lib/ceph/mgr/mgr_module.py", line 845, in remote
2019-05-02T22:25:20.283 INFO:teuthology.orchestra.run.smithi167.stderr:    args, kwargs)
2019-05-02T22:25:20.284 INFO:teuthology.orchestra.run.smithi167.stderr:ImportError: Module not found
2019-05-02T22:25:20.284 INFO:teuthology.orchestra.run.smithi167.stderr:) v1 ==== 614+0+0 (2804853677 0 0) 0x7ff16c115110 con 0x7ff14c0073f0
2019-05-02T22:25:20.284 INFO:teuthology.orchestra.run.smithi167.stderr:2019-05-02 22:25:20.277 7ff1697fa700 20 mgrc handle_command_reply command_reply(tid 0: -22 Traceback (most recent call last):
2019-05-02T22:25:20.284 INFO:teuthology.orchestra.run.smithi167.stderr:  File "/usr/lib/ceph/mgr/telemetry/module.py", line 328, in handle_command
2019-05-02T22:25:20.284 INFO:teuthology.orchestra.run.smithi167.stderr:    self.self_test()
2019-05-02T22:25:20.284 INFO:teuthology.orchestra.run.smithi167.stderr:  File "/usr/lib/ceph/mgr/telemetry/module.py", line 384, in self_test
2019-05-02T22:25:20.285 INFO:teuthology.orchestra.run.smithi167.stderr:    self.compile_report()
2019-05-02T22:25:20.285 INFO:teuthology.orchestra.run.smithi167.stderr:  File "/usr/lib/ceph/mgr/telemetry/module.py", line 291, in compile_report
2019-05-02T22:25:20.285 INFO:teuthology.orchestra.run.smithi167.stderr:    report['crashes'] = self.gather_crashinfo()
2019-05-02T22:25:20.285 INFO:teuthology.orchestra.run.smithi167.stderr:  File "/usr/lib/ceph/mgr/telemetry/module.py", line 214, in gather_crashinfo
2019-05-02T22:25:20.286 INFO:teuthology.orchestra.run.smithi167.stderr:    errno, crashids, err = self.remote('crash', 'do_ls', '', '')
2019-05-02T22:25:20.286 INFO:teuthology.orchestra.run.smithi167.stderr:  File "/usr/lib/ceph/mgr/mgr_module.py", line 845, in remote
2019-05-02T22:25:20.286 INFO:teuthology.orchestra.run.smithi167.stderr:    args, kwargs)
2019-05-02T22:25:20.286 INFO:teuthology.orchestra.run.smithi167.stderr:ImportError: Module not found
2019-05-02T22:25:20.286 INFO:teuthology.orchestra.run.smithi167.stderr:) v1
2019-05-02T22:25:20.287 INFO:teuthology.orchestra.run.smithi167.stderr:Error EINVAL: Traceback (most recent call last):
2019-05-02T22:25:20.287 INFO:teuthology.orchestra.run.smithi167.stderr:  File "/usr/lib/ceph/mgr/telemetry/module.py", line 328, in handle_command
2019-05-02T22:25:20.287 INFO:teuthology.orchestra.run.smithi167.stderr:    self.self_test()
2019-05-02T22:25:20.287 INFO:teuthology.orchestra.run.smithi167.stderr:  File "/usr/lib/ceph/mgr/telemetry/module.py", line 384, in self_test
2019-05-02T22:25:20.288 INFO:teuthology.orchestra.run.smithi167.stderr:    self.compile_report()
2019-05-02T22:25:20.288 INFO:teuthology.orchestra.run.smithi167.stderr:  File "/usr/lib/ceph/mgr/telemetry/module.py", line 291, in compile_report
2019-05-02T22:25:20.288 INFO:teuthology.orchestra.run.smithi167.stderr:    report['crashes'] = self.gather_crashinfo()
2019-05-02T22:25:20.288 INFO:teuthology.orchestra.run.smithi167.stderr:  File "/usr/lib/ceph/mgr/telemetry/module.py", line 214, in gather_crashinfo
2019-05-02T22:25:20.288 INFO:teuthology.orchestra.run.smithi167.stderr:    errno, crashids, err = self.remote('crash', 'do_ls', '', '')
2019-05-02T22:25:20.289 INFO:teuthology.orchestra.run.smithi167.stderr:  File "/usr/lib/ceph/mgr/mgr_module.py", line 845, in remote
2019-05-02T22:25:20.289 INFO:teuthology.orchestra.run.smithi167.stderr:    args, kwargs)
2019-05-02T22:25:20.289 INFO:teuthology.orchestra.run.smithi167.stderr:ImportError: Module not found

http://pulpito.ceph.com/yuriw-2019-05-02_16:49:37-rados-wip-yuri5-testing-2019-04-30-2026-mimic-distro-basic-smithi/3919085/

@tchaikov tchaikov deleted the tchaikov:mimic-39132 branch May 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.