Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: mon/OSDMonitor: further improve prepare_command_pool_set E2BIG error message #27647

Merged
merged 1 commit into from May 1, 2019

Conversation

Projects
None yet
4 participants
@smithfarm
Copy link
Contributor

commented Apr 17, 2019

d2c0fe9 improved this error message,
but at least one user suggested it could be improved further by suggesting
that the pg_num be increased in smaller increments.

This commit is not cherry-picked from master because 4d3407b
(merged for Nautilus) removed the error message in question.

Fixes: http://tracker.ceph.com/issues/39353
Signed-off-by: Nathan Cutler ncutler@suse.com

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
mon/OSDMonitor: further improve prepare_command_pool_set E2BIG error …
…message

d2c0fe9 improved this error message,
but it can be improved further by suggesting that the pg_num be increased in
smaller increments.

This commit is not cherry-picked from master because 4d3407b
(merged for Nautilus) removed the error message in question.

Fixes: http://tracker.ceph.com/issues/39353
Signed-off-by: Nathan Cutler <ncutler@suse.com>

@smithfarm smithfarm added this to the mimic milestone Apr 17, 2019

@smithfarm smithfarm requested review from tchaikov, jecluis and badone Apr 17, 2019

@smithfarm smithfarm changed the title mon/OSDMonitor: further improve prepare_command_pool_set E2BIG error message mimic: mon/OSDMonitor: further improve prepare_command_pool_set E2BIG error message Apr 17, 2019

@badone

badone approved these changes Apr 17, 2019

Copy link
Contributor

left a comment

LGTM thanks! Not sure what the unit test failure is about as I can't see any relationship. Maybe try rebasing?

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2019

@badone Since about a week ago this failure has been happening in all mimic PRs 👎

@xiexingguo

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

Not sure what the unit test failure is about as I can't see any relationship

Should be addressed by #27606 :-)

@badone

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2019

@xiexingguo thanks! So once that merges rebasing WILL fix it \o/

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

jenkins test make check

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

jenkins retest this please

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

@yuriw yuriw merged commit 33c82a0 into ceph:mimic May 1, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.