Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: rgw: failed to pass test_bucket_create_naming_bad_punctuation in s3test #27666

Merged
merged 2 commits into from May 6, 2019

Conversation

Projects
None yet
5 participants

joke-lee and others added some commits Apr 7, 2018

rgw: should recode canonical_uri when caculate s3v4 auth
fix: http://tracker.ceph.com/issues/23587

Signed-off-by: yuliyang <yuliyang@cmss.chinamobile.com>
(cherry picked from commit 919a897)
rgw: s3: awsv4 drop special handling for x-amz-credential
While s3 docs mention that every byte must be urlencoded, they are relaxed in
its implementation, when testing this behaviour on aws s3 itself, they seem to
be relaxed in handling aws credentials of the form

X-Amz-Credential=access1/20180817T123456Z/us-east-1...

wherein

X-Amz-Credential=access1%2F2018...

is expected. This allows for clients requesting the urls in both forms to
succeed as aws s3 does at the moment

Fixes: http://tracker.ceph.com/issues/26965
Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
(cherry picked from commit 25e1d2a)

@smithfarm smithfarm self-assigned this Apr 18, 2019

@smithfarm smithfarm added this to the mimic milestone Apr 18, 2019

@smithfarm smithfarm requested review from mattbenjamin and cbodley Apr 18, 2019

@smithfarm smithfarm added rgw and removed core labels Apr 18, 2019

@smithfarm smithfarm changed the title mimic: rgw:failed to pass test_bucket_create_naming_bad_punctuation in s3test mimic: rgw: failed to pass test_bucket_create_naming_bad_punctuation in s3test Apr 18, 2019

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

jenkins re-test this please

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

jenkins test docs

@yuriw

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

@yuriw yuriw merged commit a7d5e07 into ceph:mimic May 6, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.