Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: rgw: resolve bugs and clean up garbage collection code #27796

Merged
merged 1 commit into from May 6, 2019

Conversation

Projects
None yet
4 participants
@cbodley
Copy link
Contributor

commented Apr 25, 2019

@cbodley cbodley added this to the mimic milestone Apr 25, 2019

@cbodley

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

jenkins test make check

rgw: resolve bugs and clean up garbage collection code
Does a number of things to clean up rgw gc code:

  * adds additional logging to make future debugging easier.
  * resolves bug where the truncated flag was not always set correctly
    in gc_iterate_entries
  * resolves bug where marker in RGWGC::process was not advanced
  * resolves bug in which gc entries with a zero-length chain
    were not trimmed
  * resolves bug where same gc entry tag was added to list for
    deletion multiple times

Fixes: http://tracker.ceph.com/issues/38454

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
(cherry picked from commit 73d7d36)

Conflicts:
	src/rgw/rgw_gc.cc dout() vs ldpp_dout()

@cbodley cbodley force-pushed the cbodley:wip-38713 branch from 7af389c to a598ccc Apr 29, 2019

@smithfarm smithfarm requested a review from ivancich May 1, 2019

@ivancich

This comment has been minimized.

Copy link
Member

commented May 1, 2019

@cbodley thanks for backporting this!

@yuriw

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

@yuriw yuriw merged commit b3b4e98 into ceph:mimic May 6, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.