Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Update bluestore config docs - fix typo (as -> has) #27845

Merged
merged 1 commit into from May 1, 2019

Conversation

Projects
None yet
4 participants
@mykaul
Copy link
Contributor

commented Apr 29, 2019

Update bluestore config - fix typo (as -> has)

Signed-off-by: Yaniv Kaul ykaul@redhat.com

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
@ifed01

ifed01 approved these changes Apr 29, 2019

@tchaikov

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes, in this case, it would be "doc: ".

also, could you add a "Signed-off-by" line at the end of your commit message? "git commit -s" will do the trick for you. see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#1-sign-your-work

@mykaul mykaul changed the title Update bluestore config - fix typo (as -> has) Update bluestore config docs - fix typo (as -> has) Apr 29, 2019

@mykaul mykaul changed the title Update bluestore config docs - fix typo (as -> has) Doc: Update bluestore config docs - fix typo (as -> has) Apr 29, 2019

doc/rados: Update bluestore config - fix typo
as -> has

Signed-off-by: Yaniv Kaul <ykaul@redhat.com>

@tchaikov tchaikov force-pushed the mykaul:patch-1 branch from d08be96 to b42a085 May 1, 2019

@tchaikov tchaikov merged commit 60da1c0 into ceph:mimic May 1, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.