Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: osd: shutdown recovery_request_timer earlier #27938

Merged
merged 1 commit into from May 9, 2019

Conversation

Projects
None yet
4 participants
@pdvian
Copy link

commented May 3, 2019

Zengran Zhang Prashant D
osd: shutdown recovery_request_timer earlier
recovery_request_timer may hold some QueuePeeringEvts which PGRef,
if we dont shutdown it earlier, it potentially cause the PGRef leak
when kicking pg.

Fixes: https://tracker.ceph.com/issues/38945

Signed-off-by: Zengran Zhang <zhangzengran@sangfor.com.cn>
(cherry picked from commit bb41bdf)

Conflicts:
	src/osd/OSD.cc : Resolved in shutdown and start_shutdown

@smithfarm smithfarm added this to the mimic milestone May 3, 2019

@smithfarm smithfarm added the core label May 3, 2019

@smithfarm smithfarm requested review from tchaikov and liewegas May 3, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

@yuriw yuriw merged commit 7d88a70 into ceph:mimic May 9, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.