Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: core: ENOENT in collection_move_rename on EC backfill target #27943

Merged
merged 3 commits into from May 8, 2019

Conversation

Projects
None yet
3 participants
@smithfarm
Copy link
Contributor

commented May 3, 2019

neha-ojha added some commits Mar 4, 2019

osd/PG: skip rollforward when !transaction_applied during append_log()
Earlier, we did pg_log.roll_forward(&handler), when
!transaction_applied, which advanced the crt and trimmed the entries
in rollforward(). Due to this, during _merge_object_divergent_entries(),
when we tried to rollback entries, those objects were not found in the
backend, and thus we hit this bug http://tracker.ceph.com/issues/36739.

With this change, we are advancing the crt value, without deleting the
objects, so that _merge_object_divergent_entries() does not fail
because of deleted objects.

Fixes: http://tracker.ceph.com/issues/36739
Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit 17419ee)
osd/PG: change error to dout in _scan_rollback_obs()
This message is now expected during scrubbing, since we do not delete
objects during a rollforward when !transaction_applied.

Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit b8e62e6)
osd/PG: !transaction_applied is true for async_recovery_targets as well
Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit 71996da)

@smithfarm smithfarm self-assigned this May 3, 2019

@smithfarm smithfarm added this to the mimic milestone May 3, 2019

@smithfarm smithfarm changed the title mimic: ENOENT in collection_move_rename on EC backfill target mimic: core: ENOENT in collection_move_rename on EC backfill target May 3, 2019

@smithfarm smithfarm requested a review from neha-ojha May 3, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

@yuriw yuriw merged commit fc627b2 into ceph:mimic May 8, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-38879-mimic branch May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.