Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: Allow viewing and setting pool quotas #27945

Merged
merged 2 commits into from Jul 3, 2019

Conversation

@bk201
Copy link
Contributor

commented May 3, 2019

Allow managing pool quotas in both frontend and backend.

Fixes: https://tracker.ceph.com/issues/36559

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

@LenzGr LenzGr requested review from Devp00l, tspmelo and votdev May 6, 2019

@LenzGr LenzGr requested review from alfonsomthd and a2batic May 6, 2019

@bk201

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

jenkins retest this please

@bk201 bk201 force-pushed the bk201:wip-36559 branch from e89dd0c to 72ccf9b May 7, 2019

@LenzGr LenzGr requested a review from tspmelo May 7, 2019

@Devp00l

Devp00l approved these changes May 8, 2019

Copy link
Contributor

left a comment

LGTM, thanks a lot for adding tests initially to test the new behavior 👍

@bk201 bk201 force-pushed the bk201:wip-36559 branch from 72ccf9b to 0477d80 May 10, 2019

@bk201 bk201 requested a review from tspmelo May 10, 2019

@tspmelo
Copy link
Contributor

left a comment

just missing 1 thing.

@bk201 bk201 force-pushed the bk201:wip-36559 branch from 0477d80 to 6313749 May 10, 2019

@callithea

This comment has been minimized.

Copy link
Member

commented May 13, 2019

jenkins test dashboard

1 similar comment
@bk201

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

jenkins test dashboard

@callithea callithea added the needs-qa label May 16, 2019

@callithea

This comment has been minimized.

Copy link
Member

commented May 17, 2019

@a2batic
Copy link
Member

left a comment

(Sorry I forgot to restart my cluster)

@a2batic
Copy link
Member

left a comment

Working fine for me

@bk201 bk201 force-pushed the bk201:wip-36559 branch from 6313749 to e622e91 May 20, 2019

@bk201 bk201 requested a review from alfonsomthd May 20, 2019

@tchaikov

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

retest this please.

@callithea

This comment has been minimized.

@callithea

This comment has been minimized.

Copy link
Member

commented May 23, 2019

jenkins test make check

@tchaikov

This comment has been minimized.

Copy link
Contributor

commented May 27, 2019

retest this please.

@tchaikov

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2019

@LenzGr good to merge?

@LenzGr

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

@LenzGr good to merge?

Looks good, just needs a rebase to adapt to the latest changes to the Pools QA tests.

@LenzGr LenzGr added the needs-rebase label Jun 17, 2019

@bk201 bk201 force-pushed the bk201:wip-36559 branch from e622e91 to e3cde7c Jun 18, 2019

bk201 added some commits Jun 18, 2019

mgr/dashboard: support pool quotas in backend
Fixes: https://tracker.ceph.com/issues/36559
Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
mgr/dashboard: allow managing pool quotas in frontend
Fixes: https://tracker.ceph.com/issues/36559
Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>

@bk201 bk201 force-pushed the bk201:wip-36559 branch from e3cde7c to 809e0a2 Jun 18, 2019

formControlName: 'max_bytes',
replaceFn: this.formatter.toBytes,
editable: true,
resetValue: this.editing ? 0 : undefined

This comment has been minimized.

Copy link
@bk201

bk201 Jun 18, 2019

Author Contributor

When editing a pool, clearing quota field should disable pool quota.

This comment has been minimized.

Copy link
@bk201

bk201 Jun 18, 2019

Author Contributor

I've rebased and found previous changes missed this recommendation: #27945 (comment)

When editing a pool, clearing quota fields should disable corresponding quotas.
So I think it's better to start another round of review and test again, since pool testing code on master changed too.

externalFieldName: 'quota_max_objects',
formControlName: 'max_objects',
editable: true,
resetValue: this.editing ? 0 : undefined

This comment has been minimized.

Copy link
@bk201

bk201 Jun 18, 2019

Author Contributor

When editing a pool, clearing quota field should disable pool quota.

@callithea

This comment has been minimized.

@callithea
Copy link
Member

left a comment

Tested it on my local system, lgtm!

@ricardoasmarques
Copy link
Member

left a comment

lgtm

@ricardoasmarques

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

jenkins test make check arm64

@tspmelo

tspmelo approved these changes Jul 2, 2019

@LenzGr LenzGr merged commit 8a6aec4 into ceph:master Jul 3, 2019

5 of 6 checks passed

make check (arm64) make check failed
Details
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph dashboard tests ceph dashboard tests succeeded
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.