Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: rpm: missing dependency on python34-ceph-argparse from python34-cephfs (and others?) #27949

Merged
merged 3 commits into from Jul 17, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented May 3, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented May 8, 2019

@cbodley

This comment has been minimized.

Copy link
Contributor

cbodley commented May 9, 2019

tests failing to install packages with:

2019-05-09T16:56:01.598 INFO:teuthology.orchestra.run.smithi089.stdout:The following packages have unmet dependencies:
2019-05-09T16:56:01.638 INFO:teuthology.orchestra.run.smithi089.stdout: ceph-common : Depends: python-cephfs (= 13.2.5-331-gd86b928-1bionic) but it is not going to be installed
2019-05-09T16:56:01.639 INFO:teuthology.orchestra.run.smithi089.stdout:               Depends: python-ceph-argparse (= 13.2.5-331-gd86b928-1bionic) but it is not going to be installed
2019-05-09T16:56:01.641 INFO:teuthology.orchestra.run.smithi089.stdout: python-ceph : Depends: python-cephfs (= 13.2.5-331-gd86b928-1bionic) but it is not going to be installed
Depends: ${misc:Depends},
${python:Depends},
Replaces: ceph-common (<< 14.0.0)
Breaks: ceph-common (<< 14.0.0)

This comment has been minimized.

Copy link
@vshankar

vshankar May 31, 2019

Contributor

looks like this might be causing failure such as (from http://qa-proxy.ceph.com/teuthology/yuriw-2019-05-09_15:50:59-rgw-wip-yuri4-testing-2019-05-08-2017-mimic-distro-basic-smithi/3942466/teuthology.log)

019-05-09T16:56:01.598 INFO:teuthology.orchestra.run.smithi089.stdout:The following packages have unmet dependencies:
2019-05-09T16:56:01.638 INFO:teuthology.orchestra.run.smithi089.stdout: ceph-common : Depends: python-cephfs (= 13.2.5-331-gd86b928-1bionic) but it is not going to be installed
2019-05-09T16:56:01.639 INFO:teuthology.orchestra.run.smithi089.stdout:               Depends: python-ceph-argparse (= 13.2.5-331-gd86b928-1bionic) but it is not going to be installed
2019-05-09T16:56:01.641 INFO:teuthology.orchestra.run.smithi089.stdout: python-ceph : Depends: python-cephfs (= 13.2.5-331-gd86b928-1bionic) but it is not going to be installed
2019-05-09T16:56:01.657 INFO:teuthology.orchestra.run.smithi064.stdout:Building dependency tree...
2019-05-09T16:56:01.658 INFO:teuthology.orchestra.run.smithi064.stdout:Reading state information...
2019-05-09T16:56:01.658 INFO:teuthology.orchestra.run.smithi089.stderr:W: --force-yes is deprecated, use one of the options starting with --allow instead.
2019-05-09T16:56:01.659 INFO:teuthology.orchestra.run.smithi089.stderr:E: Unable to correct problems, you have held broken packages.

@batrick @smithfarm

This comment has been minimized.

Copy link
@smithfarm

smithfarm May 31, 2019

Author Contributor

Ah, it seems I forgot to adapt these version guards to mimic:

Replaces: ceph-common (<< 14.0.0)
Breaks: ceph-common (<< 14.0.0)
tchaikov added 3 commits Jul 14, 2018
in `cephfs.pyx` we `cimport rados`, and in
LibCephFs.create_with_rados(), Rados.cluster is accesssed without GIL,
so we need to import the rados module for cephfs to ensure that it's
safe to access this attribute without GIL.

dh_python2 and dh_python3 cannot fill ${python:Depends} and
${python3:Depends} with this dependency, so we need to set it
explicitly.

Fixes: http://tracker.ceph.com/issues/24918
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit b35823c)
…vailable"

This reverts commit c0b7aab.

python3-ceph-argparse is required by ceph_volume_client.py. hence we do
need it as a dependency of python3-cephfs.

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 8d8099b)
python-ceph-argparse is required by ceph_volume_client.py. hence we do
need list it as a dependency of python-cephfs.

Fixes: http://tracker.ceph.com/issues/24919
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 03c7bee)

Conflicts:
	ceph.spec.in (trivial resolution)
        debian/control (adapted version guards to mimic)
@smithfarm smithfarm force-pushed the smithfarm:wip-37613-mimic branch from 60a8d6c to c3f33b5 May 31, 2019
@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Jul 9, 2019

@yuriw yuriw merged commit d5cb5ff into ceph:mimic Jul 17, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm deleted the smithfarm:wip-37613-mimic branch Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.