Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upmimic: rpm: missing dependency on python34-ceph-argparse from python34-cephfs (and others?) #27949
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tests failing to install packages with:
|
This comment has been minimized.
This comment has been minimized.
debian/control
Outdated
Depends: ${misc:Depends}, | ||
${python:Depends}, | ||
Replaces: ceph-common (<< 14.0.0) | ||
Breaks: ceph-common (<< 14.0.0) |
This comment has been minimized.
This comment has been minimized.
vshankar
May 31, 2019
Contributor
looks like this might be causing failure such as (from http://qa-proxy.ceph.com/teuthology/yuriw-2019-05-09_15:50:59-rgw-wip-yuri4-testing-2019-05-08-2017-mimic-distro-basic-smithi/3942466/teuthology.log)
019-05-09T16:56:01.598 INFO:teuthology.orchestra.run.smithi089.stdout:The following packages have unmet dependencies:
2019-05-09T16:56:01.638 INFO:teuthology.orchestra.run.smithi089.stdout: ceph-common : Depends: python-cephfs (= 13.2.5-331-gd86b928-1bionic) but it is not going to be installed
2019-05-09T16:56:01.639 INFO:teuthology.orchestra.run.smithi089.stdout: Depends: python-ceph-argparse (= 13.2.5-331-gd86b928-1bionic) but it is not going to be installed
2019-05-09T16:56:01.641 INFO:teuthology.orchestra.run.smithi089.stdout: python-ceph : Depends: python-cephfs (= 13.2.5-331-gd86b928-1bionic) but it is not going to be installed
2019-05-09T16:56:01.657 INFO:teuthology.orchestra.run.smithi064.stdout:Building dependency tree...
2019-05-09T16:56:01.658 INFO:teuthology.orchestra.run.smithi064.stdout:Reading state information...
2019-05-09T16:56:01.658 INFO:teuthology.orchestra.run.smithi089.stderr:W: --force-yes is deprecated, use one of the options starting with --allow instead.
2019-05-09T16:56:01.659 INFO:teuthology.orchestra.run.smithi089.stderr:E: Unable to correct problems, you have held broken packages.
This comment has been minimized.
This comment has been minimized.
smithfarm
May 31, 2019
Author
Contributor
Ah, it seems I forgot to adapt these version guards to mimic:
Replaces: ceph-common (<< 14.0.0)
Breaks: ceph-common (<< 14.0.0)
in `cephfs.pyx` we `cimport rados`, and in LibCephFs.create_with_rados(), Rados.cluster is accesssed without GIL, so we need to import the rados module for cephfs to ensure that it's safe to access this attribute without GIL. dh_python2 and dh_python3 cannot fill ${python:Depends} and ${python3:Depends} with this dependency, so we need to set it explicitly. Fixes: http://tracker.ceph.com/issues/24918 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit b35823c)
python-ceph-argparse is required by ceph_volume_client.py. hence we do need list it as a dependency of python-cephfs. Fixes: http://tracker.ceph.com/issues/24919 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 03c7bee) Conflicts: ceph.spec.in (trivial resolution) debian/control (adapted version guards to mimic)
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
smithfarm commentedMay 3, 2019
http://tracker.ceph.com/issues/37613