Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: tools: crushtool crash on Fedora 28 and newer #27986

Merged
merged 2 commits into from Jul 17, 2019

Conversation

@pdvian
Copy link

pdvian commented May 7, 2019

badone added 2 commits Apr 11, 2019
When compiled with _GLIBCXX_ASSERTIONS we see an assert due to UB of
passing the address of an empty vector. Use vector's data member
function instead of address of array syntax.

Fixes: http://tracker.ceph.com/issues/39174

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
(cherry picked from commit a950ac2)
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
(cherry picked from commit 5b6b5c5)
@tchaikov tchaikov added this to the mimic milestone May 7, 2019
@smithfarm smithfarm requested review from liewegas, tchaikov and badone May 7, 2019
@badone
badone approved these changes May 8, 2019
Copy link
Contributor

badone left a comment

Thanks guys, looks fine to me.

@badone badone added the needs-qa label May 8, 2019
@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Jul 8, 2019

@yuriw yuriw merged commit fb38cc7 into ceph:mimic Jul 17, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm changed the title mimic: crushtool crash on Fedora 28 and newer mimic: tools: crushtool crash on Fedora 28 and newer Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.