Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
mgr / volumes: background purge queue for subvolumes #28003
Standalone mixin classes to support background purge operation
The usage of subvolume group (and its association with the
Signed-off-by: Venky Shankar firstname.lastname@example.org
May 28, 2019
I had to introduce some additional changes in the connection pool logic to make this work with #27856. The reason being that since the (now python) tests are executed as teuthology tasks, I see teuthology (at least with vstart_runner) removing (and recreating) filesystem at times in-between executing tests. This was causing the test to hang as the cached filesystem handle (from the pool) is invalid since the filesystem got removed behind the scene. I added a workaround for this by checking the filesystem id (cached vs what's in fs map), and reconnect to the filesystem if required. #27856 passes with these changes.
batrick left a comment
We actually want to do the reverse I think: leave it as a byte string everywhere except when presenting it to the user as a message/output/exception.
paths may not be decodeable so we shouldn't try.
I will add a commit that changes this.
tests will run in 210 minutes.
@ajarr I'm satisfied to merge this. I've added a few changes. I do have a few code hygiene requests but they can be addressed when Venky returns from PTO. I'll merge this tomorrow morning assuming no issues with the tests.