Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
mimic: osd: Include dups in copy_after() and copy_up_to() #28089
Client saw out of order results in a test with a very small pg_log because a backfill/recovery sent a small number of log entries for duplicate checks. Since these copy operations are equivalent to both a copy and trim (an argument controls how many log entries transfer), we need to include any new dups with enough existing dups up to the configured maximum. Fixes: http://tracker.ceph.com/issues/39304 Signed-off-by: David Zafman <email@example.com> (cherry picked from commit 00f279d) Conflicts: src/osd/PeeringState.cc contents in src/osd/PG.cc src/osd/osd_types.cc (trivial)
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.