Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: librbd: ensure compare-and-write doesn't skip compare after copyup #28133

Merged
merged 5 commits into from Jul 11, 2019

Conversation

@dillaman
Copy link
Contributor

dillaman commented May 15, 2019

idryomov added 5 commits Feb 19, 2019
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 60f0421)
This is counter-intuitive and doesn't match the behavior of either
other compare ops (cmpxattr, omap_cmp) or write ops.

Fixes: http://tracker.ceph.com/issues/38383
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 4daddf0)

Conflicts:
	don't change method signature but copy bufferlist
cmpext is a read operation.  As such, it shouldn't be creating objects
or extending them and it should accept snapshots.

The compare code is completely broken, resulting in false positives
(i.e. failures to detect mismatches) in many cases.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 6a2986f)
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 032ccce)
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 1f411c0)
@dillaman dillaman added this to the mimic milestone May 15, 2019
@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Jul 8, 2019

@yuriw yuriw merged commit f03afc4 into ceph:mimic Jul 11, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.