Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
mimic: librbd: ensure compare-and-write doesn't skip compare after copyup #28133
This is counter-intuitive and doesn't match the behavior of either other compare ops (cmpxattr, omap_cmp) or write ops. Fixes: http://tracker.ceph.com/issues/38383 Signed-off-by: Ilya Dryomov <firstname.lastname@example.org> (cherry picked from commit 4daddf0) Conflicts: don't change method signature but copy bufferlist
cmpext is a read operation. As such, it shouldn't be creating objects or extending them and it should accept snapshots. The compare code is completely broken, resulting in false positives (i.e. failures to detect mismatches) in many cases. Signed-off-by: Ilya Dryomov <email@example.com> (cherry picked from commit 6a2986f)
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.