Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
mimic: rbd: filter out group/trash snapshots from snap_list #28138
Do not zero-fill the BitVector's bitset prior to decoding the data. Additionally, only read-update-modify the portions of the footer that are potentially affected by the updated state. Fixes: http://tracker.ceph.com/issues/38538 Signed-off-by: Jason Dillaman <firstname.lastname@example.org> (cherry picked from commit 071671f) Conflicts: src/cls/rbd/cls_rbd.cc src/cls/rbd/cls_rbd_client.h src/common/bit_vector.hpp src/test/common/test_bit_vector.cc src/test/librbd/test_ObjectMap.cc Trivial conflicts with bufferlist::begin/cbegin and assert/ceph_assert
Fixes: [root@ ~]# rbd snap rm img1@snap1 [root@ ~]# rbd snap ls img1 -a SNAPID NAME SIZE TIMESTAMP NAMESPACE 4 f2e82bd1-e2ff-4a6b-aaef-5a12a2b23a30 100 MiB Sat Aug 18 08:48:34 2018 trash (snap1) [root@ ~]# rbd snap purge img1 Removing all snapshots: 0% complete...failed. rbd: removing snaps failed: (2) No such file or directory Signed-off-by: songweibin <email@example.com> (cherry picked from commit 2c79a49)
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.