Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
mimic: librbd: add missing shutdown states to managed lock helper #28151
The PRE_SHUTTING_DOWN and SHUTTING_DOWN states were missed in the 'is_state_shutdown' helper method. This resulted in rbd-mirror potentially entering an infinite loop during shutdown. http://tracker.ceph.com/issues/38387 Signed-off-by: Jason Dillaman <firstname.lastname@example.org> (cherry picked from commit 82af571)
If the mirroring object is missing, complete the initialization and continue to retry in the background. This is useful for cases where the remote doesn't (yet) have mirroring enabled but the remote pool watcher initialization is delaying the leader watcher promotion to the point where the leader is blacklisted by its peers. Signed-off-by: Jason Dillaman <email@example.com> (cherry picked from commit 80954cd)
If the image replay was canceled prior to the start of the bootstrap stage, the image replayer would be stuck attempting to shut down if the bootstrap is paused behind an image sync. Signed-off-by: Jason Dillaman <firstname.lastname@example.org> (cherry picked from commit 91b8a24) Conflicts: src/tools/rbd_mirror/ImageReplayer.cc: trivial resolution
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.