Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: mgr: deadlock #28161

Merged
merged 2 commits into from Jul 10, 2019

Conversation

@pdvian
Copy link

pdvian commented May 17, 2019

xiexingguo added 2 commits Mar 30, 2019
Holding GIL and run mon_command turns out to be easily deadlock-prone.
https://tracker.ceph.com/issues/35985 is a typical report, and here is
another.

Fix by using PyModuleConfig's own lock for protection of concurrent
accesses, which should be sufficient enough.

Fixes: http://tracker.ceph.com/issues/39040
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
(cherry picked from commit 96b7319)

Conflicts:
	src/mgr/BaseMgrModule.cc : Resolved in ceph_config_set
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
(cherry picked from commit 5108860)

Conflicts:
	src/mgr/ActivePyModules.cc : Resolved in set_store
@smithfarm smithfarm added the mgr label May 17, 2019
@smithfarm smithfarm added this to the mimic milestone May 17, 2019
@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Jul 9, 2019

@yuriw yuriw merged commit dd6a3d8 into ceph:mimic Jul 10, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.