Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: mgr/dashboard: Fix various RGW issues #28210

Merged
merged 1 commit into from Jul 24, 2019

Conversation

@votdev
Copy link
Contributor

votdev commented May 22, 2019

  • Fix handling of tenanted users
  • Better exception handling if RGW backend is not available
  • RGW user/bucket "max. size" should be hidden when "user/bucket quota" is not enabled
  • Fix bug in loading user quota.

Fixes: https://tracker.ceph.com/issues/38800

partial manual backport of 6199597
partial manual backport of e6f130d
partial manual backport of 945e790
partial manual backport of a98bca6
partial manual backport of 975736a

This fix is not cherry-picked because the code was completely re-worked for Nautilus (codebase is too far apart).

Signed-off-by: Volker Theile vtheile@suse.com

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
@votdev votdev changed the title mgr/dashboard: Fix various RGW issues mimic: mgr/dashboard: Fix various RGW issues May 22, 2019
@votdev votdev added this to the mimic milestone May 22, 2019
@LenzGr LenzGr added the needs-qa label May 27, 2019
@smithfarm smithfarm self-requested a review May 28, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented May 28, 2019

@votdev Can you edit the commit message (using git commit --amend) so it explains why this fix cannot be implemented as a cherry-pick from master or nautilus?

One option is to:

  1. find out which commit fixed the issue in master
  2. append to commit message: partial manual backport of $SHA1 with brief explanation why the master commit cannot be cherry-picked in its entirety

But really all that's necessary is a brief explanation why the commit cannot be cherry-picked - for example: "This fix is not cherry-picked because the code was completely re-worked for nautilus."

@smithfarm smithfarm added needs-review and removed needs-qa labels May 28, 2019
@smithfarm smithfarm changed the title mimic: mgr/dashboard: Fix various RGW issues [AFTER: #28208, #28209] mimic: mgr/dashboard: Fix various RGW issues May 28, 2019
@votdev votdev force-pushed the votdev:fix_rgw_issue branch from c0aa169 to f476400 May 29, 2019
@votdev votdev marked this pull request as ready for review Jul 2, 2019
@votdev votdev changed the title [AFTER: #28208, #28209] mimic: mgr/dashboard: Fix various RGW issues [AFTER: #28208] mimic: mgr/dashboard: Fix various RGW issues Jul 9, 2019
@votdev votdev mentioned this pull request Jul 9, 2019
1 of 3 tasks complete
@votdev votdev changed the title [AFTER: #28208] mimic: mgr/dashboard: Fix various RGW issues mimic: mgr/dashboard: Fix various RGW issues Jul 16, 2019
@tspmelo

This comment has been minimized.

Copy link
Contributor

tspmelo commented Jul 19, 2019

Found a problem, but I'm not sure if caused by this PR or if another commit should be cherry-picked to fix this problem.
The RGW user form is ignoring the value of the quota.

  1. Edit a RGW user
  2. Pick an user quota size
  3. Save user
  4. Edit the same user
  5. It will show Unlimited size active
* Fix handling of tenanted users
* Better exception handling if RGW backend is not available
* RGW user/bucket "max. size" should be hidden when "user/bucket quota" is not enabled
* Fix bug in loading user quota.

Fixes: https://tracker.ceph.com/issues/38800

partial manual backport of 6199597
partial manual backport of e6f130d
partial manual backport of 945e790
partial manual backport of a98bca6
partial manual backport of 975736a

This fix is not cherry-picked because the code was completely re-worked for Nautilus (codebase is too far apart).

Signed-off-by: Volker Theile <vtheile@suse.com>
@votdev votdev force-pushed the votdev:fix_rgw_issue branch from f476400 to a4558ba Jul 19, 2019
@votdev

This comment has been minimized.

Copy link
Contributor Author

votdev commented Jul 19, 2019

Found a problem, but I'm not sure if caused by this PR or if another commit should be cherry-picked to fix this problem.
The RGW user form is ignoring the value of the quota.

1. Edit a RGW user

2. Pick an user quota size

3. Save user

4. Edit the same user

5. It will show `Unlimited size` active

Fixed by partial manual backport of 975736a.

Copy link
Contributor

tspmelo left a comment

lgtm

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Jul 23, 2019

@yuriw yuriw merged commit efd2f2f into ceph:mimic Jul 24, 2019
5 checks passed
5 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph dashboard tests ceph dashboard tests succeeded
Details
make check make check succeeded
Details
@votdev votdev deleted the votdev:fix_rgw_issue branch Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.