Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: Use serial RGW Admin OPS API calls #28223

Merged
merged 1 commit into from May 29, 2019
Merged

mgr/dashboard: Use serial RGW Admin OPS API calls #28223

merged 1 commit into from May 29, 2019

Conversation

votdev
Copy link
Member

@votdev votdev commented May 23, 2019 •
edited

This PR takes care that changes done to a RGW user are submitted (via RGW Admin OPS API) in serial and NOT in parallel.

Fixes: https://tracker.ceph.com/issues/40015

Signed-off-by: Volker Theile vtheile@suse.com

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

@votdev votdev changed the title mgr/dashboard: Submit changes in serial mgr/dashboard: Use serial RGW Admin OPS API calls May 23, 2019
@votdev votdev force-pushed the submit_requests_in_serial branch from e96a244 to 854ed40 Compare May 23, 2019 11:58
@votdev votdev added bug-fix and removed cleanup labels May 23, 2019
ricardoasmarques
ricardoasmarques approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@ricardoasmarques ricardoasmarques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgmt. This fixes the "race" issues that I've faced while using this feature in the past. Thanks.

@votdev
Copy link
Member Author

votdev commented May 23, 2019

jenkins retest this please

@tchaikov
Copy link
Contributor

retest this please.

@LenzGr LenzGr requested review from Devp00l and p-se May 27, 2019 08:59
s0nea
s0nea approved these changes May 27, 2019
View reviewed changes
Copy link
Member

@s0nea s0nea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@votdev
Copy link
Member Author

votdev commented May 27, 2019

jenkins retest this please

@votdev
mgr/dashboard: Use serial RGW Admin OPS API calls
2cc32e6 
This PR takes care that changes done to a RGW user are submitted (via RGW Admin OPS API) in serial and NOT in parallel.

Fixes: https://tracker.ceph.com/issues/40015

Signed-off-by: Volker Theile <vtheile@suse.com>
@votdev votdev force-pushed the submit_requests_in_serial branch from 854ed40 to 2cc32e6 Compare May 27, 2019 13:38
@votdev
Copy link
Member Author

votdev commented May 28, 2019

jenkins test make check arm64

@LenzGr LenzGr merged commit 9bf13f1 into ceph:master May 29, 2019
@votdev votdev deleted the submit_requests_in_serial branch May 29, 2019 09:34
@callithea callithea mentioned this pull request Nov 12, 2019
Merged
@shyukri shyukri mentioned this pull request Jan 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s0nea s0nea s0nea approved these changes

@ricardoasmarques ricardoasmarques ricardoasmarques approved these changes

@LenzGr LenzGr Awaiting requested review from LenzGr

@tspmelo tspmelo Awaiting requested review from tspmelo

@Devp00l Devp00l Awaiting requested review from Devp00l

@p-se p-se Awaiting requested review from p-se

Assignees
No one assigned
Labels
bug-fix dashboard
Projects
None yet
Milestone
No milestone
5 participants
@votdev @tchaikov @s0nea @ricardoasmarques @LenzGr