Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: rgw: allow radosgw-admin to list bucket w --allow-unordered #28230

Merged
merged 1 commit into from Jul 22, 2019

Conversation

@ivancich
Copy link
Member

commented May 23, 2019

rgw: allow radosgw-admin to list bucket w --allow-unordered
Presently the `radosgw-admin bucket list --bucket=<bucket>` lists the
objects in lexical order. This can be an expensive operation since
objects are not stored in bucket index shards in order and a selection
sort process is done across all bucket index shards.

By allowing the user to add the "--allow-unordered" command-line flag,
a more efficient bucket listing is enabled. This is particularly
important for buckets with a large number of objects.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
(cherry picked from commit 12452c4)
@mattbenjamin
Copy link
Contributor

left a comment

lgtm

@ivancich ivancich added needs-qa and removed DNM labels May 23, 2019

@tchaikov tchaikov added this to the nautilus milestone May 28, 2019

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

jenkins re-test this please

@lordcirth

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

I see that this PR is blocking the 14.2.2 release. Are we waiting for reviewers?

@ivancich

This comment has been minimized.

Copy link
Member Author

commented Jul 5, 2019

It got a good review. at this point it requires 6 total reviews, though.... (Or someone who has enhanced privileges.)

@mattbenjamin

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

@smithfarm is this good to go?

Matt

@ivancich

This comment has been minimized.

Copy link
Member Author

commented Jul 6, 2019

I just did a QA run on teuthology. There were no regressions.

@ivancich ivancich removed the needs-qa label Jul 6, 2019

@ivancich

This comment has been minimized.

Copy link
Member Author

commented Jul 6, 2019

@yuriw Can we merge this?

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2019

@yuriw yuriw merged commit 53a549e into ceph:nautilus Jul 22, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.