Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: Display iSCSI "logged in" info #28265

Merged
merged 1 commit into from Jul 3, 2019

Conversation

@ricardoasmarques
Copy link
Member

commented May 28, 2019

With this PR, the user will be able to see if an initiator is logged-in or logged-out.

Additionally the host alias, ip, and the target portal will be displayed in the initiator details:

Screenshot from 2019-05-28 12-26-42

Fixes: https://tracker.ceph.com/issues/40046

Signed-off-by: Ricardo Marques rimarques@suse.com

@ricardoasmarques ricardoasmarques requested a review from tspmelo May 28, 2019

@ricardoasmarques ricardoasmarques force-pushed the ricardoasmarques:wip-iscsi-logged-in branch from d40e40d to 4c88693 May 29, 2019

@tspmelo

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

jenkins retest this please

@ricardoasmarques ricardoasmarques force-pushed the ricardoasmarques:wip-iscsi-logged-in branch 2 times, most recently from 4c37f99 to 2c2491c Jun 8, 2019

@ricardoasmarques

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2019

jenkins test make check arm64

1 similar comment
@ricardoasmarques

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2019

jenkins test make check arm64

@@ -8,7 +8,7 @@
<span>&nbsp;</span>

<span class="label"
[ngClass]="{'label-success': ['in', 'up'].includes(node.status), 'label-danger': ['down', 'out'].includes(node.status)}">
[ngClass]="{'label-success': ['in', 'up', 'logged_in'].includes(node.status), 'label-danger': ['down', 'out', 'logged_out'].includes(node.status)}">

This comment has been minimized.

Copy link
@tspmelo

tspmelo Jun 10, 2019

Contributor

Since node.status can only be logged_in or logged_out, I think we can remove the other status.

This comment has been minimized.

Copy link
@ricardoasmarques

@ricardoasmarques ricardoasmarques force-pushed the ricardoasmarques:wip-iscsi-logged-in branch from 2c2491c to 1c85e2d Jun 10, 2019

@tspmelo
Copy link
Contributor

left a comment

lgtm

@ricardoasmarques ricardoasmarques force-pushed the ricardoasmarques:wip-iscsi-logged-in branch from 1c85e2d to da0fe3a Jun 10, 2019

@ricardoasmarques

This comment has been minimized.

Copy link
Member Author

commented Jun 11, 2019

jenkins test make check arm64

3 similar comments
@ricardoasmarques

This comment has been minimized.

Copy link
Member Author

commented Jun 12, 2019

jenkins test make check arm64

@ricardoasmarques

This comment has been minimized.

Copy link
Member Author

commented Jun 13, 2019

jenkins test make check arm64

@callithea

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

jenkins test make check arm64

mgr/dashboard: Display iSCSI "logged in" info
Fixes: https://tracker.ceph.com/issues/40046

Signed-off-by: Ricardo Marques <rimarques@suse.com>

@ricardoasmarques ricardoasmarques force-pushed the ricardoasmarques:wip-iscsi-logged-in branch from da0fe3a to 71ed058 Jun 19, 2019

@ricardoasmarques

This comment has been minimized.

Copy link
Member Author

commented Jul 2, 2019

jenkins test make check arm64

@LenzGr LenzGr added the feature label Jul 3, 2019

@LenzGr LenzGr merged commit 8c76bd1 into ceph:master Jul 3, 2019

5 of 6 checks passed

make check (arm64) make check failed
Details
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph dashboard tests ceph dashboard tests succeeded
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.