objecter: delete the osdmap correctly when receiving new ones #28304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were erroneously decoding a new map and then pointer-assigning it without deleting the existing map. Fix that! Fixes: http://tracker.ceph.com/issues/39723 Signed-off-by: Greg Farnum <gfarnum@redhat.com>
|
Looks like this has been broken since the assignment was introduced in d98ace1. Guess we just got "lucky" in not having it turn up previously. This is not even compile tested but I presume I didn't screw that up, so once it passes "make check" we should be good to merge. |
jdurgin
approved these changes
May 29, 2019
xiexingguo
approved these changes
May 30, 2019
|
Oh thanks Xie! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were erroneously decoding a new map and then pointer-assigning it
without deleting the existing map. Fix that!
Fixes: http://tracker.ceph.com/issues/39723
Signed-off-by: Greg Farnum gfarnum@redhat.com