Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: rgw: remove_olh_pending_entries() does not limit the number of xattrs to remove #28348

Merged
merged 1 commit into from Jul 8, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented May 31, 2019

If there are too many entries to send in a single osd op, the osd rejects
the request with EINVAL. This error happens in follow_olh(), which means
that requests against the object logical head (requests with no version
id) can't be resolved to the current object version. In multisite, this
also causes data sync to get stuck in retries

Fixes: http://tracker.ceph.com/issues/39118

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 3805ea6)

Conflicts:
	src/rgw/rgw_rados.cc
- mimic ref.ioctx.operate() call takes ref.oid instead of ref.obj.oid
@smithfarm smithfarm self-assigned this May 31, 2019
@smithfarm smithfarm added this to the mimic milestone May 31, 2019
@smithfarm smithfarm added bug fix core rgw and removed core labels May 31, 2019
@smithfarm smithfarm requested a review from cbodley May 31, 2019
@cbodley

This comment has been minimized.

Copy link
Contributor

cbodley commented Jun 3, 2019

jenkins test make check

@cbodley
cbodley approved these changes Jun 3, 2019
@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Jul 1, 2019

@yuriw yuriw merged commit b8fb847 into ceph:mimic Jul 8, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm deleted the smithfarm:wip-39179-mimic branch Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.