Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: mgr/balancer: fix fudge #28399

Merged
merged 1 commit into from Jul 10, 2019
Merged

mimic: mgr/balancer: fix fudge #28399

merged 1 commit into from Jul 10, 2019

Conversation

@xiexingguo
Copy link
Member

xiexingguo commented Jun 5, 2019

next_* simply record some intermediate results when balancer tries
to find something to optimize, whereas best_* are used for the
final outputs.

Fix by comparing origin_ow with best_ow when determining if we
should use a valid fudge value.

Signed-off-by: xie xingguo xie.xingguo@zte.com.cn
(cherry picked from commit 8f46a35)

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
next_* simply record some intermediate results when balancer tries
to find something to optimize, whereas best_* are used for the
final outputs.

Fix by comparing origin_ow with best_ow when determining if we
should use a valid fudge value.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
(cherry picked from commit 8f46a35)
@xiexingguo xiexingguo added the mgr label Jun 5, 2019
@xiexingguo xiexingguo added this to the mimic milestone Jun 5, 2019
@xiexingguo xiexingguo mentioned this pull request Jun 5, 2019
0 of 3 tasks complete
@smithfarm smithfarm requested a review from tchaikov Jun 26, 2019
@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Jul 9, 2019

@yuriw yuriw merged commit 08dfbfa into ceph:mimic Jul 10, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@xiexingguo xiexingguo deleted the xiexingguo:wip-fudege-for-m branch Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.