Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: rgw: return ERR_NO_SUCH_BUCKET early while evaluating bucket policy #28422

Merged
merged 1 commit into from Jul 8, 2019

Conversation

@pdvian
Copy link

pdvian commented Jun 6, 2019

Right now we create a ERR_NO_SUCH_BUCKET ret code but continue further
processing. Since this ret code isn't returned at any stage we end up creating a
bucket instance anyway which shouldn't happen and then succeeding the client
call in cases like put bucket versioning. Return an error code early in these
cases

Fixes: http://tracker.ceph.com/issues/38420
Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
(cherry picked from commit cf66a6d)
@smithfarm smithfarm added this to the mimic milestone Jun 10, 2019
@smithfarm smithfarm added the rgw label Jun 10, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Jun 10, 2019

Make check terminated after successfully completing 15 tests. (?)

./run-make-check.sh: line 32: 32686 Terminated              $DRY_RUN ctest $CHECK_MAKEOPTS --output-on-failure
Build step 'Execute shell' marked build as failure
[PostBuildScript] - Executing post build scripts.
[ceph-pull-requests] $ /bin/sh -xe /tmp/jenkins1786266379558095148.sh
+ sudo reboot
FATAL: Unable to delete script file /tmp/jenkins1786266379558095148.sh
@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Jun 10, 2019

jenkins re-test this please

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Jul 1, 2019

@yuriw yuriw merged commit b1b1634 into ceph:mimic Jul 8, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.