Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesmimic: osd: Output Base64 encoding of CRC header if binary data present #28503
Conversation
Add optional paramter so cleanbin() for bufferlist can include "Base64:" Fixes: https://tracker.ceph.com/issues/39582 Signed-off-by: David Zafman <dzafman@redhat.com> (cherry picked from commit eea239c) Conflicts: src/include/util.h : Resolved for cleanbin src/osd/ReplicatedBackend.cc : Resolved for util.h
|
LGTM |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pdvian commentedJun 12, 2019
http://tracker.ceph.com/issues/39737