Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: osd: Output Base64 encoding of CRC header if binary data present #28503

Merged
merged 1 commit into from Jul 1, 2019

Conversation

@pdvian
Copy link

pdvian commented Jun 12, 2019

Add optional paramter so cleanbin() for bufferlist can include "Base64:"

Fixes: https://tracker.ceph.com/issues/39582

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit eea239c)

Conflicts:
	src/include/util.h : Resolved for cleanbin
	src/osd/ReplicatedBackend.cc : Resolved for util.h
@tchaikov tchaikov added this to the mimic milestone Jun 12, 2019
@smithfarm smithfarm requested review from dzafman, liewegas and tchaikov Jun 12, 2019
Copy link
Member

dzafman left a comment

LGTM

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Jun 26, 2019

@yuriw yuriw merged commit d46a48f into ceph:mimic Jul 1, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.