Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: mon: paxos: introduce new reset_pending_committing_finishers for safety #28528

Merged
merged 1 commit into from Jul 31, 2019

Conversation

@pdvian
Copy link

commented Jun 13, 2019

mon: paxos: introduce new reset_pending_committing_finishers for safety
There are asserts about the state of the system and pending_finishers which can
be triggered by running arbitrary commands through again. They are correct
when not restarting, but when we do restart we need to take care to preserve
the same invariants as appropriate. Use this function to be careful about
the order of committing_finishers v pending_finishers and to make sure they're
both empty before any Contexts actually get called.

We also reorder a call to finish_contexts on the waiting_for_writeable list for
similar reasons.

Fixes: http://tracker.ceph.com/issues/39484

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
(cherry picked from commit b17caec)

@smithfarm smithfarm added this to the nautilus milestone Jun 13, 2019

@gregsfortytwo
Copy link
Member

left a comment

Reviewed-by: Greg Farnum gfarnum@redhat.com

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

@yuriw yuriw merged commit f6ef7a3 into ceph:nautilus Jul 31, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.