Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
mimic: mon: paxos: introduce new reset_pending_committing_finishers for safety #28540
There are asserts about the state of the system and pending_finishers which can be triggered by running arbitrary commands through again. They are correct when not restarting, but when we do restart we need to take care to preserve the same invariants as appropriate. Use this function to be careful about the order of committing_finishers v pending_finishers and to make sure they're both empty before any Contexts actually get called. We also reorder a call to finish_contexts on the waiting_for_writeable list for similar reasons. Fixes: http://tracker.ceph.com/issues/39484 Signed-off-by: Greg Farnum <firstname.lastname@example.org> (cherry picked from commit b17caec)
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.