Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: mds: fix corner case of replaying open sessions #28579

Merged
merged 2 commits into from Jul 17, 2019
Merged

Conversation

@ukernel
Copy link
Member

ukernel commented Jun 17, 2019

Marking a session dirty may flush all existing dirty sessions. MDS
calls Server::finish_force_open_sessions() for log event that opens
multiple sessions. The function marks sessions dirty one by one. So
sessions opened by a log event may get flushed partially.

When replaying a log event that opens multiple sessions, mds need to
check if some of these sessions have already been flushed.

Fixes: https://tracker.ceph.com/issues/40211
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
(cherry picked from commit 8e0ddc9)

 Conflicts:
	src/mds/SessionMap.cc
	src/mds/SessionMap.h
	src/mds/journal.cc
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
(cherry picked from commit cd6f65b)

 Conflicts:
	src/mds/journal.cc
@ukernel ukernel force-pushed the ukernel:mimic-40342 branch from b8d8c65 to 5a5a5f9 Jun 17, 2019
@smithfarm smithfarm requested a review from batrick Jun 17, 2019
@smithfarm smithfarm added this to the mimic milestone Jun 17, 2019
@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Jul 9, 2019

@yuriw yuriw merged commit dadbdb0 into ceph:mimic Jul 17, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@ukernel ukernel deleted the ukernel:mimic-40342 branch Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.