Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: rgw: Librgw doesn't GC deleted object correctly #28648

Merged
merged 2 commits into from Jul 30, 2019

Conversation

@pdvian
Copy link

commented Jun 19, 2019

taoCH and others added 2 commits Dec 21, 2018
rgw_file: allocate new id for continued request
Fixed: http://tracker.ceph.com/issues/37734

Signed-off-by: Tao Chen <chentao@umcloud.com>
(cherry picked from commit e2cdb04)
rgw_file: unify allocations of request id
The fix by Tao Chen <chentao@umcloud.com> for construction of the
request id in RGWWriteRequests/RGWContinuedReq paths--just writes,
effectively--revealed that RGWRequest::id was being set to zero
in general, while a valid request id was being assigned to
req_state.

This implies that code which the RGWRequest::id of non-write requests
would still use an invalid value, so avoid that by initializing
RGWRequest::id in all RGWLibRequests, and propagating its value
to req_state.  This still works as intended for RGWWriteRequest.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit 5135634)

@cbodley cbodley added this to the nautilus milestone Jun 19, 2019

@cbodley cbodley requested a review from mattbenjamin Jun 19, 2019

@smithfarm smithfarm changed the title nautilus: Librgw doesn't GC deleted object correctly nautilus: rgw: Librgw doesn't GC deleted object correctly Jun 20, 2019

@smithfarm smithfarm requested a review from cbodley Jun 20, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

@yuriw yuriw merged commit 6768663 into ceph:nautilus Jul 30, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.