Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: mgr/dashboard: notify the user about unset 'mon_allow_pool_delete' flag beforehand #28833

Merged
merged 2 commits into from Aug 12, 2019

Conversation

@s0nea
Copy link
Member

commented Jul 2, 2019

s0nea added 2 commits May 28, 2019
mgr/dashboard: add a description tooltip for disabled items
Add the possibility to show a description tooltip for disabled
menu items. The description is optional. If no description is
given for a specific menu item, no tooltip will be shown.

Signed-off-by: Tatjana Dehler <tdehler@suse.com>
(cherry picked from commit 4a28b52)
mgr/dashboard: consider 'mon_allow_pool_delete' flag
Check if the 'mon_allow_pool_delete' flag is set. If not,
disable the menu item to delete a pool. Show also a description
why the item is disabled.

Fixes: https://tracker.ceph.com/issues/39533
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
(cherry picked from commit b5eb71d)

@s0nea s0nea self-assigned this Jul 2, 2019

@s0nea s0nea added this to the nautilus milestone Jul 2, 2019

@s0nea s0nea added bug fix core dashboard and removed core labels Jul 2, 2019

@callithea
Copy link
Member

left a comment

Tested it locally, lgtm!

@Devp00l
Copy link
Contributor

left a comment

LGTM

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

@yuriw yuriw merged commit af48315 into ceph:nautilus Aug 12, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@s0nea s0nea deleted the s0nea:wip-40616-nautilus branch Aug 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.