Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: os/bluestore/bluefs_types: consolidate contiguous extents #28862

Merged
merged 1 commit into from Aug 21, 2019

Conversation

@liewegas
Copy link
Member

commented Jul 3, 2019

If we allocate a new extent that is contiguous with the last extent,
just extend it. This avoids having long vectors of continguous extents
when a single large extent would suffice--especially with log files.

Signed-off-by: Sage Weil sage@redhat.com
(cherry picked from commit 4f3ce9b)

@liewegas liewegas requested a review from ifed01 Jul 3, 2019

@liewegas liewegas added the bluestore label Jul 3, 2019

@liewegas liewegas added this to the nautilus milestone Jul 3, 2019

@ifed01
ifed01 approved these changes Jul 3, 2019
@yuriw

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

@liewegas pls rebase

--- pr 28862 --- pulling https://github.com/liewegas/ceph.git branch wip-bluefs-extents-nautilus
remote: Enumerating objects: 5, done.
remote: Counting objects: 100% (5/5), done.
remote: Total 6 (delta 5), reused 5 (delta 5), pack-reused 1
Unpacking objects: 100% (6/6), done.
From https://github.com/liewegas/ceph

  • branch wip-bluefs-extents-nautilus -> FETCH_HEAD
    Auto-merging src/os/bluestore/bluefs_types.h
    CONFLICT (content): Merge conflict in src/os/bluestore/bluefs_types.h
    Automatic merge failed; fix conflicts and then commit the result.
    Traceback (most recent call last):
    File "/home/yuriw/wip_master/src/script/build-integration-branch", line 62, in
    assert not r
    AssertionError
os/bluestore/bluefs_types: consolidate contiguous extents
If we allocate a new extent that is contiguous with the last extent,
just extend it.  This avoids having long vectors of continguous extents
when a single large extent would suffice--especially with log files.

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 4f3ce9b)

@liewegas liewegas force-pushed the liewegas:wip-bluefs-extents-nautilus branch from d8c8567 to 096033b Aug 20, 2019

@liewegas liewegas removed the needs-rebase label Aug 20, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

@yuriw yuriw added the needs-qa label Aug 20, 2019

@yuriw yuriw merged commit 3a6de89 into ceph:nautilus Aug 21, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.