Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: mgr/dashboard: cephfs multimds graphs stack together #28911

Merged
merged 1 commit into from Jul 24, 2019

Conversation

@bk201
Copy link
Contributor

bk201 commented Jul 8, 2019

@bk201 bk201 self-assigned this Jul 8, 2019
@bk201 bk201 added this to the mimic milestone Jul 8, 2019
@bk201 bk201 changed the title mimic: mgr/dashboard: cephfs multimds graphs stack together mgr/dashboard: cephfs multimds graphs stack together Jul 8, 2019
@bk201

This comment has been minimized.

Copy link
Contributor Author

bk201 commented Jul 8, 2019

jenkins test dashboard

@bk201 bk201 changed the title mgr/dashboard: cephfs multimds graphs stack together mimic: mgr/dashboard: cephfs multimds graphs stack together Jul 8, 2019
@bk201 bk201 requested review from tspmelo, LenzGr, ricardoasmarques and votdev Jul 8, 2019
@bk201 bk201 added the DNM label Jul 8, 2019
@bk201

This comment has been minimized.

Copy link
Contributor Author

bk201 commented Jul 8, 2019

The ceph dashboard tests job fails with an error, need to re-test this PR after it's fixed.

@bk201

This comment has been minimized.

Copy link
Contributor Author

bk201 commented Jul 11, 2019

Need to rebase and re-test after #28954 is merged.

Also include some UI enhancements:
- Fix MDS chart container is not aligned to other components.
- Show header on client table.

Fixes: https://tracker.ceph.com/issues/37579

Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
(cherry picked from commit a3e76ac)

Conflicts:
	src/pybind/mgr/dashboard/frontend/src/app/ceph/cephfs/cephfs-clients/cephfs-clients.component.html
	src/pybind/mgr/dashboard/frontend/src/app/ceph/cephfs/cephfs-detail/cephfs-detail.component.html

files above are renamed, their paths in mimic are:
	src/pybind/mgr/dashboard/frontend/src/app/ceph/cephfs/clients/clients.component.html
	src/pybind/mgr/dashboard/frontend/src/app/ceph/cephfs/cephfs/cephfs.component.html
@bk201 bk201 force-pushed the bk201:wip-40660-mimic branch from 5651ee4 to 068b095 Jul 16, 2019
@bk201 bk201 removed the DNM label Jul 16, 2019
@bk201

This comment has been minimized.

Copy link
Contributor Author

bk201 commented Jul 16, 2019

rebased and retested because #28954 is merged.

@rjfd
rjfd approved these changes Jul 16, 2019
Copy link
Contributor

rjfd left a comment

lgtm

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Jul 23, 2019

@yuriw yuriw merged commit c80a612 into ceph:mimic Jul 24, 2019
5 checks passed
5 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph dashboard tests ceph dashboard tests succeeded
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.