Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: mgr/dashboard: Dentries value of MDS daemon in Filesystems page is inconsistent with ceph fs status output #28912

Merged
merged 1 commit into from Aug 12, 2019

Conversation

@bk201
Copy link
Contributor

commented Jul 8, 2019

mgr/dashboard: use mds_mem.dn for fs dentries
mds_mem.dn is more accurate for representing fs dentries.
Switching from mds.inodes to mds_mem.dn creates consistency with output
of `ceph fs status` command.

Also in Cephfs counter chart, series of mds_mem.ino is displayed now
for consistency.

See #15255

Fixes: https://tracker.ceph.com/issues/40097
Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
(cherry picked from commit 7c6f46f)

@bk201 bk201 self-assigned this Jul 8, 2019

@bk201 bk201 added this to the nautilus milestone Jul 8, 2019

@bk201 bk201 changed the title nautilus: mgr/dashboard: Dentries value of MDS daemon in Filesystems page is inconsistent with ceph fs stauts output mgr/dashboard: Dentries value of MDS daemon in Filesystems page is inconsistent with ceph fs stauts output Jul 8, 2019

@bk201

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

jenkins test dashboard

@bk201 bk201 changed the title mgr/dashboard: Dentries value of MDS daemon in Filesystems page is inconsistent with ceph fs stauts output nautilus: mgr/dashboard: Dentries value of MDS daemon in Filesystems page is inconsistent with ceph fs stauts output Jul 8, 2019

@LenzGr
LenzGr approved these changes Jul 8, 2019
Copy link
Contributor

left a comment

LGTM!

@bk201 bk201 requested review from ricardoasmarques and votdev Jul 11, 2019

@LenzGr LenzGr changed the title nautilus: mgr/dashboard: Dentries value of MDS daemon in Filesystems page is inconsistent with ceph fs stauts output nautilus: mgr/dashboard: Dentries value of MDS daemon in Filesystems page is inconsistent with ceph fs status output Jul 12, 2019

@LenzGr
LenzGr approved these changes Jul 12, 2019
Copy link
Contributor

left a comment

LGTM! Thank you.

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

@yuriw yuriw merged commit 3e59530 into ceph:nautilus Aug 12, 2019

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph dashboard tests ceph dashboard tests succeeded
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.