Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: doc: Improved dashboard feature overview #28919

Merged
merged 1 commit into from Jul 24, 2019

Conversation

@LenzGr
Copy link
Contributor

commented Jul 8, 2019

Added some newly added features, improved wording.

Signed-off-by: Lenz Grimmer lgrimmer@suse.com
(cherry picked from commit f90c111)

  • Updates documentation if necessary
doc: Improved dashboard feature overview
Added some newly added features, improved wording.

Signed-off-by: Lenz Grimmer <lgrimmer@suse.com>
(cherry picked from commit f90c111)

@LenzGr LenzGr added this to the nautilus milestone Jul 8, 2019

@LenzGr LenzGr changed the title doc: Improved dashboard feature overview nautilus: doc: Improved dashboard feature overview Jul 8, 2019

@LenzGr LenzGr requested review from s0nea and votdev Jul 8, 2019

@s0nea

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

jenkins render docs

@tspmelo
tspmelo approved these changes Jul 8, 2019
@p-se
p-se approved these changes Jul 8, 2019
@ceph-jenkins

This comment has been minimized.

Copy link
Collaborator

commented Jul 8, 2019

Doc render available at http://docs.ceph.com/ceph-prs/28919/

@s0nea
s0nea approved these changes Jul 8, 2019
@votdev
votdev approved these changes Jul 9, 2019
@votdev

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

jenkins test make check

@votdev votdev requested review from Devp00l and ricardoasmarques Jul 9, 2019

@p-se

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

@votdev I wonder why need more reviews on this PR 🤔

@votdev

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

@votdev I wonder why need more reviews on this PR thinking

At least 6 approving reviews are required to merge, currently we have 5.

@ricardoasmarques
Copy link
Member

left a comment

lgtm

@tspmelo tspmelo added the needs-qa label Jul 22, 2019

@smithfarm smithfarm merged commit ba7decb into ceph:nautilus Jul 24, 2019

6 checks passed

Docs: build check OK - docs built
Details
Docs: render build OK - docs rendered
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph dashboard tests ceph dashboard tests succeeded
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.