Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: mgr/dashboard: Add, update and remove translations #28938

Merged
merged 1 commit into from Aug 12, 2019

Conversation

@Exotelis
Copy link
Contributor

commented Jul 9, 2019

@Exotelis Exotelis added the dashboard label Jul 9, 2019

@Exotelis Exotelis requested review from LenzGr, tspmelo and Devp00l Jul 9, 2019

@smithfarm smithfarm changed the title mgr/dashboard: Add, update and remove translations nautilus: mgr/dashboard: Add, update and remove translations Jul 9, 2019

@smithfarm smithfarm added this to the nautilus milestone Jul 9, 2019

@Exotelis Exotelis force-pushed the Exotelis:i18n-nautilus branch 2 times, most recently from 6f5d0e3 to 1d87741 Jul 9, 2019

@Exotelis

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

jenkins test dashboard

@LenzGr
LenzGr approved these changes Jul 9, 2019
Copy link
Contributor

left a comment

LGTM! Thank you.

@Exotelis

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

jenkins test dashboard

@LenzGr LenzGr added the cleanup label Jul 11, 2019

'pt-PT' = 'Português',
'es-ES' = 'Español',
'zh-CN' = '中文'
'pt-BR' = 'Português (brasileiro)',

This comment has been minimized.

Copy link
@tspmelo

tspmelo Jul 11, 2019

Contributor

Just notice we are using this string for PT.
I would suggest just use Português, as there is no need to differentiate and we don't do it for other languages.
This should also be applied in master.

Suggested change
'pt-BR' = 'Português (brasileiro)',
'pt-BR' = 'Português',

This comment has been minimized.

Copy link
@LenzGr

LenzGr Jul 12, 2019

Contributor

This should also be applied in master.

Agreed. Can you please take care of this @Exotelis ?

This comment has been minimized.

Copy link
@Exotelis

Exotelis Jul 16, 2019

Author Contributor

Removing the '(brasileiro)' is ok.
However, I'd prefer to keep the language identifier as it is, since we had both languages on our project in the past. So on transifex we also have the pt_BR identifier and I'd like to keep it consistent.
If this is okay for you I'd just update the language text.

mgr/dashboard: Add, update and remove translations
Adds Italian, Japanese, Korean, Portuguese (Brazil) and Chinese (Taiwan) languages files
Updates the Czech, German, Spanish, French, Indonesian, Polish and Chinese (China) translations
Removes Portuguese (Portugal) since Portuguese (Brazil) has been added and is better maintained

This manual backport of 4794890 is not a cherry-pick because the
difference between the language files of master and nautilus started to grow. I'd like to avoid
loosing translations that should be in nautilus but are no longer available on master.

Fixes: http://tracker.ceph.com/issues/40446
Signed-off-by: Sebastian Krah <skrah@suse.com>

@Exotelis Exotelis force-pushed the Exotelis:i18n-nautilus branch from 1d87741 to c0deeb6 Jul 19, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

@yuriw yuriw merged commit fb33f1f into ceph:nautilus Aug 12, 2019

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph dashboard tests ceph dashboard tests succeeded
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.