Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: mgr/dashboard: Fix run-frontend-e2e-tests.sh #28954

Merged
merged 1 commit into from Jul 15, 2019
Merged

Conversation

@bk201
Copy link
Contributor

bk201 commented Jul 10, 2019

e2e tests were always returning positive result, even when they failed.

Fixed problem with jq, where it was failing when it was not receiving a string.

Fixes: http://tracker.ceph.com/issues/40707

Signed-off-by: Kiefer Chang kiefer.chang@suse.com
Signed-off-by: Tiago Melo tmelo@suse.com
(cherry picked from commit ad293e1)

Conflicts:
src/pybind/mgr/dashboard/run-frontend-e2e-tests.sh

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
e2e tests were always returning positive result, even when they failed.

Fixed problem with jq, where it was failing when it was not receiving a string.

Fixes: http://tracker.ceph.com/issues/40707

Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
Signed-off-by: Tiago Melo <tmelo@suse.com>
(cherry picked from commit ad293e1)

Conflicts:
	src/pybind/mgr/dashboard/run-frontend-e2e-tests.sh
@bk201 bk201 marked this pull request as ready for review Jul 10, 2019
@bk201

This comment has been minimized.

Copy link
Contributor Author

bk201 commented Jul 10, 2019

jenkins test dashboard

@bk201

This comment has been minimized.

Copy link
Contributor Author

bk201 commented Jul 10, 2019

jenkins retest this please

@callithea callithea changed the title mgr/dashboard: Fix run-frontend-e2e-tests.sh mgr/dashboard: Fix e2e test script Jul 10, 2019
@callithea

This comment has been minimized.

Copy link
Member

callithea commented Jul 10, 2019

jenkins test dashboard

@callithea callithea changed the title mgr/dashboard: Fix e2e test script mgr/dashboard: Fix Fix run-frontend-e2e-tests.sh Jul 10, 2019
@callithea callithea changed the title mgr/dashboard: Fix Fix run-frontend-e2e-tests.sh mgr/dashboard: Fix run-frontend-e2e-tests.sh Jul 10, 2019
@LenzGr
LenzGr approved these changes Jul 10, 2019
Copy link
Contributor

LenzGr left a comment

LGTM

@LenzGr LenzGr added this to the mimic milestone Jul 10, 2019
Copy link
Member

callithea left a comment

Tests have been executed successfully this time, lgtm!

@bk201 bk201 changed the title mgr/dashboard: Fix run-frontend-e2e-tests.sh mimic: mgr/dashboard: Fix run-frontend-e2e-tests.sh Jul 11, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Jul 11, 2019

@bk201 Next time please don't edit the original commit message - i.e. everything above the (cherry picked from ....) line should remain the same as in the master commit. Information can be added after that line. So the commit message would be fine if you had added these lines

Fixes: http://tracker.ceph.com/issues/40707

Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>

after the "(cherry picked from ...)" line, instead of before.

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Jul 11, 2019

@bk201

This comment has been minimized.

Copy link
Contributor Author

bk201 commented Jul 12, 2019

@bk201 Next time please don't edit the original commit message - i.e. everything above the (cherry picked from ....) line should remain the same as in the master commit. Information can be added after that line. So the commit message would be fine if you had added these lines

Sorry about that. Since Yuri already labeled this PR for testing, I will not amend the commit.

@yuriw yuriw merged commit 241abb2 into ceph:mimic Jul 15, 2019
5 checks passed
5 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph dashboard tests ceph dashboard tests succeeded
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.