Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: os/bluestore: create the tail when first set FLAG_OMAP #28963

Merged
merged 1 commit into from Jul 30, 2019

Conversation

@ifed01
Copy link
Contributor

commented Jul 10, 2019

os/bluestore: create the tail when first set FLAG_OMAP
the omap iterator when listing omap use the tail of '~', when the iterator moved to the last key of the omapswe wanted, we will try to call extra next(), usually this will be another object's omap header(with '-'). IF there are some deleted key or tombstones, rocksdb will fall in the loop of FindNextUserEntryInternal until find a valid key, so it will travels all dead key in mid and read the sst file heavily.

Signed-off-by: Tao Ning <ningtao@sangfor.com.cn>
(cherry picked from commit 0d01fb0)

@ifed01 ifed01 added this to the nautilus milestone Jul 10, 2019

@ifed01 ifed01 requested a review from liewegas Jul 10, 2019

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

169/171 Test #126: mgr-dashboard-frontend-unittests ........***Failed 585.78 sec

failure is unrelated to this PR

retest this please

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

@yuriw yuriw merged commit f37ebcd into ceph:nautilus Jul 30, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@ifed01 ifed01 deleted the ifed01:wip-ifed-add-omap-tail-nau branch Jul 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.