luminous: os/bluestore: >2GB bluefs writes #28965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KernelDevice::aio_{submit,write,read}() are critical paths. calling
cct->_conf->subsys.should_gather() multi-times is not optimal. the
downside of this issue is that if the aio is printed, the size of
buffer in PrebufferedStreambuf could be large if the number of iov is
large, that could be a heavy load to the memory subsystem.
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 67c6f76)
# Conflicts:
# src/os/bluestore/aio.cc
- adjacent to aio_queue_t::submit()
On Linux, write() (and similar system calls) will transfer at most 0x7ffff000 (2,147,479,552) bytes, it will cap data if aio pwritev more than 0x7ffff000, so we have the split the data to more aio submit. Signed-off-by: kungf <yang.wang@easystack.cn> (cherry picked from commit 4d33114) - conflict due to fd_direct instead of choose_fd()
Write 2GB to verify the blockdevice aio splitting. Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 1974f01) - fixed get_val/set_val calls - add_block_device doesn't take third arg in luminous
liewegas
changed the title
ifed01
approved these changes
Jul 10, 2019
neha-ojha
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tracker.ceph.com/issues/40650
backport of #27871