Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: os/bluestore: fix >2GB bluefs writes #28967

Merged
merged 2 commits into from Jul 18, 2019

Conversation

@liewegas
Copy link
Member

liewegas commented Jul 10, 2019

On Linux, write() (and similar system calls) will transfer at most
0x7ffff000 (2,147,479,552) bytes, it will cap data if aio pwritev
more than 0x7ffff000, so we have the split the data to more aio submit.

Signed-off-by: kungf <yang.wang@easystack.cn>
(cherry picked from commit 4d33114)

# Conflicts:
#	src/os/bluestore/KernelDevice.cc
- fd_direct vs choose_fd()
@liewegas liewegas requested review from ifed01 and neha-ojha Jul 10, 2019
@liewegas liewegas added this to the mimic milestone Jul 10, 2019
@liewegas liewegas added the bluestore label Jul 10, 2019
Write 2GB to verify the blockdevice aio splitting.

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 1974f01)

- fixed set_val/get_val usage
@liewegas liewegas force-pushed the liewegas:wip-set-aio-write-max-mimic branch from fbbbf9f to 3f9b4d7 Jul 10, 2019
@ifed01
ifed01 approved these changes Jul 10, 2019
@neha-ojha

This comment has been minimized.

Copy link
Member

neha-ojha commented Jul 10, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Jul 15, 2019

@yuriw yuriw merged commit 57268a9 into ceph:mimic Jul 18, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.