Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: mgr/dashboard: Upgrade to ceph-iscsi config v10 #28974

Merged
merged 2 commits into from Aug 12, 2019

Conversation

@ricardoasmarques
Copy link
Member

commented Jul 10, 2019

mgr/dashboard: Upgrade ceph-iscsi config to version 10
Fixes: https://tracker.ceph.com/issues/40566

Signed-off-by: Ricardo Marques <rimarques@suse.com>
(cherry picked from commit 9ac2c32)
mgr/dashboard: Rename iSCSI gateways name to FQDN
iSCSI gateways name will be automatically renamed from host
shot name to FQDN.

Fixes: https://tracker.ceph.com/issues/40566

Signed-off-by: Ricardo Marques <rimarques@suse.com>
(cherry picked from commit 51d7da1)

@ricardoasmarques ricardoasmarques self-assigned this Jul 10, 2019

@ricardoasmarques ricardoasmarques added this to the nautilus milestone Jul 10, 2019

@ricardoasmarques ricardoasmarques requested review from LenzGr and dillaman Jul 10, 2019

@ricardoasmarques

This comment has been minimized.

Copy link
Member Author

commented Jul 10, 2019

@yuriw Any chance we can include this PR in the nautilus 4.2.2 release?

Without this backport, nautilus 14.2.2 dashboard will not work with the latest ceph-iscsi 3.2 release.

Sorry for the short notice.

@ricardoasmarques ricardoasmarques added bug fix and removed bug fix labels Jul 10, 2019

@dillaman
Copy link
Contributor

left a comment

@ricardoasmarques given that one user feedback, have you verified this works correctly when shortname == FQDN? Otherwise, lgtm

@ricardoasmarques

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

@dillaman Tested with shortname == FQDN and it's working:

Screenshot from 2019-07-11 08-53-12

@LenzGr
LenzGr approved these changes Jul 11, 2019
Copy link
Contributor

left a comment

LGTM!

@dillaman
Copy link
Contributor

left a comment

👍

dillaman referenced this pull request in ceph/ceph-iscsi Jul 23, 2019
Fix deletion of gateways with multiple IPs
Switch `portal_ip_address` to a `portal_ip_addresses`
list so we can delete all registered addresses.
Additionally, all TPGs belonging to `portal_ip_addresses`
will be enabled.

Signed-off-by: Ricardo Marques <rimarques@suse.com>
@yuriw

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

@yuriw yuriw merged commit 1725425 into ceph:nautilus Aug 12, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.