Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: core: should report EINVAL in ErasureCode::parse() if m<=0 #28995

Merged
merged 3 commits into from Jul 18, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Jul 11, 2019

liewegas added 3 commits Mar 11, 2019
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 7f49be2)
Fixes: http://tracker.ceph.com/issues/38682
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit ab0a652)

Conflicts:
	src/erasure-code/clay/ErasureCodeClay.cc
- file does not exist in mimic
_DD is k=2 m=0, which we don't allow.  Switch it to cDD.

I confess I don't fully understand why this was _DD to begin with, but
I'm pretty sure mapping is there to control the order of results so that
it can be mapped to the CRUSH rule output sanely, and the coding portion
is not relevant to the test.

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 52d5797)
@smithfarm smithfarm self-assigned this Jul 11, 2019
@smithfarm smithfarm added this to the mimic milestone Jul 11, 2019
@smithfarm smithfarm requested review from liewegas, neha-ojha and tchaikov Jul 11, 2019
@smithfarm smithfarm changed the title mimic: should report EINVAL in ErasureCode::parse() if m<=0 mimic: core: should report EINVAL in ErasureCode::parse() if m<=0 Jul 11, 2019
@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Jul 15, 2019

@yuriw yuriw merged commit 82fee59 into ceph:mimic Jul 18, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm deleted the smithfarm:wip-38751-mimic branch Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.