Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: rgw: abort multipart fix #29016

Merged
merged 2 commits into from Jul 24, 2019
Merged

Conversation

@ivancich
Copy link
Member

ivancich commented Jul 12, 2019

@cbodley cbodley added this to the mimic milestone Jul 12, 2019
@cbodley cbodley changed the title rgw: mimic abort multipart fix mimic: rgw: abort multipart fix Jul 12, 2019
@ivancich ivancich added the needs-qa label Jul 12, 2019
@ivancich ivancich requested review from cbodley and theanalyst Jul 12, 2019
@ivancich ivancich added DNM and removed needs-qa labels Jul 12, 2019
ivancich added 2 commits Jun 25, 2019
Cleaning up after aborting unfinished multipart uploads is a
best-effort process. Due to the history of the multipart upload, not
all components may be found and the process needs to be robust to
that.

Presently, if a component is not found after the final call to
list_bucket_multiparts, the error propogates to the caller, but not if
the component is not found in an earlier call. This change does not
propogate that error up ever.

Additional logging is also added to multipart-related functions.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
(cherry picked from commit 51aff62)
Adding some const correctness and reformatting.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
(cherry picked from commit fb86290)
@ivancich ivancich force-pushed the ivancich:mimic-abort-multipart-fix branch from ba539c0 to 383b348 Jul 12, 2019
@ivancich ivancich requested a review from mattbenjamin Jul 19, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Jul 22, 2019

mimic is up next for release, but this fix has not been backported to nautilus yet - I just opened http://tracker.ceph.com/issues/40591 -, so I'm hesitant to queue it for 13.2.7.

@ivancich

This comment has been minimized.

Copy link
Member Author

ivancich commented Jul 22, 2019

@smithfarm This is definitely a bug and can prevent bucket deletion in some cases, and with no easy work-arounds. I understand the benefit of having bug fixes backported in backwards order. But given the problems users can have, I think it'd be better to get this into mimic sooner rather than later.

@mattbenjamin and @cbodley -- would you like to weigh in?

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Jul 23, 2019

1 similar comment
@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Jul 23, 2019

@cbodley

This comment has been minimized.

Copy link
Contributor

cbodley commented Jul 23, 2019

@ivancich i don't see much risk in applying this to mimic without nautilus, since this only affects the 'radosgw-admin bucket rm' command. the mimic version will just be able to successfully delete some buckets that it wouldn't be able to after a nautilus upgrade

@yuriw yuriw merged commit 534aad5 into ceph:mimic Jul 24, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@ivancich ivancich removed the needs-qa label Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.