Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
nautilus: mgr/dashboard: switch ng2-toastr to ngx-toastr #29050
As this means
Required manual (trivial) fixing of the following files:
Jul 17, 2019
@tspmelo done! I just did an intermediary cherry-pick in master (pre-Bootstrap PR) before bringing this to Nautilus. It applied cleanly to Nautilus, so it's a 1:1 copy of pre-BS4 master cherry-pick. Nevertheless, apart from the line
I think we should revert it (regardless this change) because it's not correct:
Besides, I like how liberal we are with NPM packages compared to Python, but perhaps downloading snapshots from "unofficial" Github forks is going too far (besides it breaks
@epuertat Nit regarding the commit message. We have an established "best practice" of leaving the original commit message intact when cherry-picking. Please limit editing of cherry-pick commit messages to the area below the "(cherry picked from ...)" line.
In this case, you added a line "Fixes: https://tracker.ceph.com/issues/40768" to the original commit message . . . this line does not relate to the original commit, but rather to the backport, so it should have been added below "(cherry picked from. . .)" and not above.
Something for next time - this one is already undergoing integration testing, so let's leave it as-is.
(This suggestion may or may not seem pedantic. FWIW, I believe there is value in having everyone adhere to a consistent format when writing backport commit messages. And all that is really needed is
Thanks @smithfarm ! Yeah, I (mostly) always follow this practice since you told me (I used
Nevertheless, I'll strictly follow these rules next time. Thanks for letting me know!