Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: mgr/dashboard: Optimize the calculation of portal IPs #29061

Merged
merged 3 commits into from Aug 12, 2019

Conversation

@s0nea
Copy link
Member

commented Jul 16, 2019

http://tracker.ceph.com/issues/40279

Contains also changes of https://tracker.ceph.com/issues/40058 due to prevent conflicts while cherry-picking.

ricardoasmarques and others added 3 commits Mar 29, 2019
mgr/dashboard: Optimize target edition when a portal is removed
Fixes: https://tracker.ceph.com/issues/38794

Signed-off-by: Ricardo Marques <rimarques@suse.com>
(cherry picked from commit f345fe3)
mgr/dashboard: Optimize portal IPs calculation
Now that portal IPs are part of the ceph-iscsi config
we don't have to calculate this information, we just
use the `portal_ip_addresses` field.

Fixes: https://tracker.ceph.com/issues/39580

Signed-off-by: Ricardo Marques <rimarques@suse.com>
(cherry picked from commit 7107bf9)
mgr/dashboard: s/portal_ip_address/portal_ip_addresses/
and take portal_ip_addresses as a list

it's a follow-up fix of #28084

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit ddeda90)

@s0nea s0nea self-assigned this Jul 16, 2019

@s0nea s0nea added this to the nautilus milestone Jul 16, 2019

@s0nea s0nea added bug fix core dashboard tests and removed core labels Jul 16, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

@yuriw yuriw merged commit 57d659e into ceph:nautilus Aug 12, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@s0nea s0nea deleted the s0nea:wip-40279-nautilus branch Aug 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.