Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: mgr/dashboard: SSL certificate upload command throws deprecation warning #29065

Merged
merged 2 commits into from Aug 15, 2019

Conversation

@s0nea
Copy link
Member

commented Jul 16, 2019

@s0nea s0nea self-assigned this Jul 16, 2019

@s0nea s0nea added this to the nautilus milestone Jul 16, 2019

@s0nea s0nea added bug fix core dashboard and removed core labels Jul 16, 2019

@rjfd
rjfd approved these changes Jul 16, 2019
Copy link
Contributor

left a comment

lgtm

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

@s0nea pls rebase:

--- pr 29065 --- pulling https://github.com/s0nea/ceph.git branch wip-40786-nautilus
remote: Enumerating objects: 10, done.
remote: Counting objects: 100% (10/10), done.
remote: Total 12 (delta 10), reused 10 (delta 10), pack-reused 2
Unpacking objects: 100% (12/12), done.
From https://github.com/s0nea/ceph
 * branch            wip-40786-nautilus -> FETCH_HEAD
Auto-merging src/pybind/mgr/dashboard/module.py
CONFLICT (content): Merge conflict in src/pybind/mgr/dashboard/module.py
Auto-merging doc/mgr/dashboard.rst
Automatic merge failed; fix conflicts and then commit the result.
Traceback (most recent call last):
  File "/home/yuriw/wip_master/src/script/build-integration-branch", line 62, in <module>
    assert not r
AssertionError
rjfd added 2 commits Apr 9, 2019
mgr/dashboard: added CLI commands to set SSL certificate and key
Fixes: https://tracker.ceph.com/issues/39123

Signed-off-by: Ricardo Dias <rdias@suse.com>
(cherry picked from commit 7648d29)
doc/mgr/dashboard: update SSL configuration instructions
Signed-off-by: Ricardo Dias <rdias@suse.com>
(cherry picked from commit 69895dd)

@s0nea s0nea force-pushed the s0nea:wip-40786-nautilus branch from 24f05cf to d2ab1e6 Aug 1, 2019

@s0nea

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2019

@s0nea pls rebase:

@yuriw thanks for the reminder - done

@tspmelo

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

jenkins test dashboard

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

@LenzGr
LenzGr approved these changes Aug 15, 2019
Copy link
Contributor

left a comment

LGTM! Thank you.

@yuriw yuriw merged commit e036ab9 into ceph:nautilus Aug 15, 2019

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph dashboard tests ceph dashboard tests succeeded
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.