Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mds: add command that config individual client session #29104

Merged
merged 2 commits into from Jul 31, 2019

Conversation

ukernel
Copy link
Contributor

@ukernel ukernel commented Jul 18, 2019

For now, the command only can change session's timeout config

Fixes: http://tracker.ceph.com/issues/40811
Signed-off-by: "Yan, Zheng" zyan@redhat.com

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

@ukernel ukernel added feature cephfs Ceph File System labels Jul 18, 2019
src/mds/MDSDaemon.cc Show resolved Hide resolved
src/mds/MDSDaemon.cc Show resolved Hide resolved
src/mds/MDSRank.cc Outdated Show resolved Hide resolved
@ukernel ukernel force-pushed the wip-40811 branch 2 times, most recently from 7eed172 to 938f7b9 Compare July 18, 2019 13:31
Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a trivial test to test_client_recovery.py.

For now, the command only can change session's timeout config

Fixes: http://tracker.ceph.com/issues/40811
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
@ukernel ukernel force-pushed the wip-40811 branch 2 times, most recently from 5dc0811 to 792477b Compare July 24, 2019 03:42
self.fs.mds_asok(['session', 'config', '%s' % mount_a_gid, 'timeout', '%s' % (session_timeout * 2)])

self.mount_a.kill();
self.mount_a.kill_cleanup()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kill_cleanup now waits for the hard reboot to complete: #28825

I guess the right thing to do here is to add a sleep after kill(), assert 2 sessions, then do kill_cleanup().

See this failure:

/ceph/teuthology-archive/pdonnell-2019-07-26_06:38:30-kcephfs-wip-pdonnell-testing-20190726.021409-distro-basic-smithi/4152101/teuthology.log

Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
@batrick batrick merged commit 4b28a4a into ceph:master Jul 31, 2019
batrick added a commit that referenced this pull request Jul 31, 2019
* refs/pull/29104/head:
	qa/cephfs: test case for timeout config of individual session
	mds: add command that config individual client session

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
@ukernel ukernel deleted the wip-40811 branch November 13, 2019 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants